Feat: support format validation#1575
Open
tico88612 wants to merge 1 commit into
Open
Conversation
Some commands don't support some formats (e.g., `yaml`, `toml`) yet; add validation to prevent users from thinking they were executed successfully. Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
tico88612
force-pushed
the
feat/format-validation
branch
from
4f14613 to
e83845f
Compare
jglogan
reviewed
May 20, 2026
Contributor
jglogan
left a comment
jglogan
left a comment
There was a problem hiding this comment.
@tico88612 this looks fine but I wonder if we may be reading the issue too literally (the description was from an AI-based analysis that we did).
I haven't looked but would it be just as easy to address the issue by adding support for YAML output for all these commands?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Fixed #1528
Some commands don't support some formats (e.g.,
yaml,toml) yet; add validation to prevent users from thinking they were executed successfully.Testing