[core] Changelog expiration skip expired changes to avoid FileNotFoundException#7923
Merged
Conversation
added 4 commits
May 20, 2026 21:23
LsomeYeah
approved these changes
May 22, 2026
Contributor
LsomeYeah
left a comment
LsomeYeah
left a comment
There was a problem hiding this comment.
LGTM with minor changes.
Comment on lines
+134
to
+135
| // This happens when retainMin >= total changelog count | ||
| // (e.g. latestSnapshotId - retainMin + 1 <= earliestChangelogId), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
If some changelogs are deleted by other job, we should ensure the commit process won't be interrupted by expiration (like ExpireSnapshotsImpl).
Tests