Skip to content

fix(e2e): repair filestorage + permissions tests #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antosubash merged 2 commits into from
May 23, 2026
Merged

fix(e2e): repair filestorage + permissions tests #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eefb07c
fix(e2e): align storage + permissions assertions with actual server b…
antosubash May 23, 2026
933dd04
Merge branch 'main' into fix/storage-and-permissions-e2e
antosubash May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/e2e/tests/flows/filestorage-crud.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,14 +153,16 @@ test.describe('FileStorage permissions', () => {
},
},
});
expect(response.status()).toBe(302);
// API endpoints return 401 for unauthenticated requests (no redirect for non-browser clients)
expect(response.status()).toBe(401);
});

test('delete is rejected', async ({ request }) => {
const response = await request.delete('/api/files/1', {
maxRedirects: 0,
});
expect(response.status()).toBe(302);
// API endpoints return 401 for unauthenticated requests (no redirect for non-browser clients)
expect(response.status()).toBe(401);
});
});
});
6 changes: 3 additions & 3 deletions tests/e2e/tests/flows/permissions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ test.describe('Permission System', () => {
});

test('can access settings page', async ({ page }) => {
await page.goto('/settings');
await page.goto('/settings/me');
await expect(page.getByRole('heading', { name: /settings/i })).toBeVisible();
});
});
Expand All @@ -25,10 +25,10 @@ test.describe('Permission System', () => {
test.use({ storageState: { cookies: [], origins: [] } });

test('admin API rejects unauthenticated request', async ({ request }) => {
const response = await request.get('/api/admin/users', {
const response = await request.get('/admin/users', {
maxRedirects: 0,
});
// Identity cookie scheme returns 302 redirect to login for unauthenticated requests
// Identity cookie scheme returns 302 redirect to login for unauthenticated browser requests
expect(response.status()).toBe(302);
});

Expand Down
Loading