Skip to content

build: update dependency puppeteer to v25#3673

Open
angular-robot wants to merge 1 commit into
angular:mainfrom
angular-robot:ng-renovate/puppeteer-25-x
Open

build: update dependency puppeteer to v25#3673
angular-robot wants to merge 1 commit into
angular:mainfrom
angular-robot:ng-renovate/puppeteer-25-x

Conversation

@angular-robot
Copy link
Copy Markdown
Contributor

@angular-robot angular-robot commented May 18, 2026

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
puppeteer (source) 24.43.125.0.2 age adoption passing confidence

  • If you want to rebase/retry this PR, check this box

Release Notes

puppeteer/puppeteer (puppeteer)

v25.0.2

Compare Source

♻️ Chores
  • puppeteer: Synchronize puppeteer versions
Dependencies
  • The following workspace dependencies were updated
🛠️ Fixes

@angular-robot angular-robot added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only] labels May 18, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the puppeteer dependency from version 24.43.0 to 25.0.2 and refreshes the pnpm-lock.yaml file. A significant issue was identified in package.json where puppeteer and puppeteer-core versions are now out of sync within the overrides section. It is recommended to update puppeteer-core to 25.0.2 as well to maintain compatibility and avoid potential runtime errors.

Comment thread bazel/rules/rules_browsers/package.json Outdated
"onlyBuiltDependencies": [],
"overrides": {
"puppeteer": "24.43.0",
"puppeteer": "25.0.2",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The puppeteer and puppeteer-core versions in the overrides section are out of sync. Since puppeteer depends on puppeteer-core, they should be updated together to the same version (25.0.2) to ensure compatibility. Leaving puppeteer-core at 24.43.0 (line 38) will cause puppeteer to use an older core, which is likely to cause runtime errors or unexpected behavior.

@angular-robot angular-robot force-pushed the ng-renovate/puppeteer-25-x branch from 7960c6a to b693f7f Compare May 18, 2026 10:52
See associated pull request for more information.
@angular-robot angular-robot force-pushed the ng-renovate/puppeteer-25-x branch from b693f7f to 8897319 Compare May 18, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant