fix(cdk/scrolling): make it easier to provide custom scrollable#33269
Open
crisbeto wants to merge 1 commit into
Open
fix(cdk/scrolling): make it easier to provide custom scrollable#33269crisbeto wants to merge 1 commit into
crisbeto wants to merge 1 commit into
Conversation
Currently the `ScrollDispatcher` only accepts a `CdkScrollable` which makes it hard for users to register their own. These changes make it so only the `ScrollDispatcherTarget` interface needs to be implemented instead.
crisbeto
force-pushed
the
scrollable-extend
branch
from
df2c18f to
d62646c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
ScrollDispatcheronly accepts aCdkScrollablewhich makes it hard for users to register their own.These changes make it so only the
ScrollDispatcherTargetinterface needs to be implemented instead.