Skip to content

Sapporo2 build system integration#1262

Open
LourensVeen wants to merge 12 commits into
amusecode:mainfrom
LourensVeen:sapporo2_build_system_integration
Open

Sapporo2 build system integration#1262
LourensVeen wants to merge 12 commits into
amusecode:mainfrom
LourensVeen:sapporo2_build_system_integration

Conversation

@LourensVeen
Copy link
Copy Markdown
Member

This adds Sapporo2 to the build system. We should merge treecode/sapporo2#16 first, and then this needs to be updated with the version hash of the new commit created by that merge.

Note that there's a commit in here that fixes the autoconf name for sapporo_light. That's unrelated and it makes absolutely no difference to anything functionally, but I discovered this copy-pasted error and decided to fix it anyway for hair splitting purposes.

Partially addresses #1209

@HannoSpreeuw HannoSpreeuw self-requested a review May 12, 2026 15:41
Comment thread lib/sapporo_2/support/configure
Comment thread lib/sapporo_2/Makefile Outdated
HannoSpreeuw
HannoSpreeuw previously approved these changes May 15, 2026
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Development Board May 15, 2026
The previous hash pointed to the Sapporo 2 repo before PR 16 "Add uninstall target to build system".
@LourensVeen
Copy link
Copy Markdown
Member Author

I've removed the -sapporo package in favour of -sapporo2. I think the only thing we need now is the make test target for Sapporo2, so that ./setup test sapporo2 will work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants