Resp img#1
Open
attiks wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore the first 2 commits, it's just white space
Third commit (https://github.com/attiks/picturefill-proposal/commit/a044619643cb8216cf43f66c0c3896656cc9e1ed) fixes a problem with IE9 and Opera if there wasn't a width set on the img element, it got cloned as width="0"
Fourth commit (https://github.com/attiks/picturefill-proposal/commit/b0ddaf21c8ab2ba2418ab78dade165a5b23363e2) copies some attributes to the newly created img tag: width, height, class, title and alt.
width and height for retina displays
class so it's easy to theme
alt is probably going away
title no idea yet