fix: eph folder key issue#1696
Conversation
github-actions
Bot
added
test:uipath-langchain
🚨 Heads up:
|
|
🚨 Heads up:
|
| """ | ||
| if folder_key is not None or folder_path is not None: | ||
| folder_key = self._resolve_folder_key(folder_key, folder_path) | ||
| folder_key = self._resolve_folder_key(folder_key, folder_path) |
There was a problem hiding this comment.
not sure I understand this change entirely. we should resolve the folder_key only when either the folder_key / folder_path are passed. otherwise, the index creation will not be folder-bound.
There was a problem hiding this comment.
here is my understanding:
there are 3 places it can get the folder key from:
- folder_key passed in from method params
- folder_path passed in from method params
- env var (from self._folder_key)
with that if statement we are not allowing it to check #3.
in all other places in the sdk we directly call _resolve_folder_key so I don't understand what is unique about ephemeral indexes that we need to wrap it an if statement.
I don't know if this inconsistency is what is causing the customer issue, but it is my best guess. and I don't see what changing it will hurt.
There was a problem hiding this comment.
when is the env var set? I think we can check if we got the folder in the request
3 participants
make sure the create ephemeral index call has folder key. follows the same path to get it as our other methods now which also checks env vars
relevant issue: https://uipath-product.slack.com/archives/C060F2VLC20/p1780340678652109?thread_ts=1779989349.104999&cid=C060F2VLC20