fix(i18n): add missing Cancel translations for Input/ComboBox/MultiComboBox (2.15)#13612
Merged
Merged
Conversation
…MultiComboBox The keys INPUT_SUGGESTIONS_CANCEL_BUTTON, MULTICOMBOBOX_DIALOG_CANCEL_BUTTON and COMBOBOX_DIALOG_CANCEL_BUTTON are defined and used in 2.15.x but their translations are missing from all non-default messagebundle_*.properties locale files, causing the English fallback Cancel to appear regardless of the user's locale on mobile suggestion/dialog popovers. Backport the translations from main, where they already exist in 2.16+. Fixes #13587
nnaydenow
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Backport the missing translations for these three i18n keys to the 2.15.x line:
INPUT_SUGGESTIONS_CANCEL_BUTTONMULTICOMBOBOX_DIALOG_CANCEL_BUTTONCOMBOBOX_DIALOG_CANCEL_BUTTONWhy
These keys are defined and used in the JS layer in 2.15.x (Input, ComboBox, MultiComboBox dialogs/suggestions on mobile) but they are missing from every
messagebundle_*.propertieslocale file in this release line. As a result, the English fallback "Cancel" is shown regardless of locale.The translations already exist on
main(and were shipped in 2.16+); this PR pulls them verbatim into the 2.15.x locale files so a 2.15.5 patch release can ship them.How
The translations are taken from
mainfor eachmessagebundle_*.propertiesfile, including the pseudo-locales (sappsd,saprigi,saptrc) anden. The sourcemessagebundle.propertiesalready contained the keys on 2.15.4, so it was untouched.Fixes #13587