Fix SelfDrop equality#2091
Open
karreiro wants to merge 1 commit into
Open
Conversation
aswamy
approved these changes
Jun 2, 2026
Contributor
aswamy
left a comment
There was a problem hiding this comment.
Looks good 👍 I also checked out the test on liquid-spec and seem consistent.
EvilGenius13
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Liquid::SelfDropcurrently behaves like a wrapper object for equality, even though every meaningful operation delegates back to the captured context. That means two separateselflookups from the same context compare as different values, leaking implementation detail into both Ruby callers and template behavior:This change makes
SelfDropequality compare the captured context identity, and alignseql?/hashwith the same rule so Ruby hash-key semantics stay coherent.