fix: Update mentor contact information for NumFOCUS and omegaUp#455
fix: Update mentor contact information for NumFOCUS and omegaUp#455omkartike wants to merge 11 commits into
Conversation
|
@omkartike is attempting to deploy a commit to the s3dfx-cyber's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ PR Validation PassedThanks @omkartike! Your PR follows the repository guidelines 🚀 |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughEnriches mentor/contact entries for NumFOCUS and omegaUp in ChangesMentor Data Updates
Privacy content and routing
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Pull Request OpenedHi @omkartike! Here's your current ranking:
Current Rank: #9 Current Score: 12 Keep contributing to climb the leaderboard 📈 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@data/mentors.json`:
- Line 1601: The JSON contains two occurrences of the "lastFetched" timestamp
set in the future (2026-05-12T00:00:00.000Z); update both "lastFetched" fields
to a non-future ISO8601 timestamp (e.g., the current date/time or
2026-05-11T00:00:00.000Z) so freshness checks won’t fail—search for the
"lastFetched" keys in this file and replace the future values at those
occurrences.
In `@privacy.html`:
- Line 57: Add descriptive aria-label attributes to the navigation regions:
update the main navigation element with class "sticky top-0 z-50 glass border-b
border-surface-container-low" to include a clear aria-label (e.g.,
aria-label="Main navigation" or similar) and likewise add an appropriate
aria-label to the footer navigation element referenced in the review (footer nav
at line 203) so screen readers can identify each navigation region; choose
concise, context-specific labels that reflect their purpose.
- Around line 9-11: The three external tags (the Tailwind script tag and the two
Google Fonts link tags) lack Subresource Integrity and crossorigin attributes;
generate SHA384 SRI hashes for each CDN URL (e.g., using curl + openssl or
https://www.srihash.org) and add integrity="sha384-..." and
crossorigin="anonymous" attributes to the <script
src="https://cdn.tailwindcss.com?plugins=forms,container-queries"></script> and
both <link href="https://fonts.googleapis.com/..." rel="stylesheet" /> tags so
the resources are validated and loaded with CORS enabled.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f33cb0ce-3d2e-44ab-b005-1db51d9c62bb
📒 Files selected for processing (3)
data/mentors.jsonindex.htmlprivacy.html
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: cubic · AI code reviewer
🧰 Additional context used
🪛 GitHub Check: SonarCloud Code Analysis
privacy.html
[warning] 9-9: Make sure not using resource integrity feature is safe here.
[warning] 10-10: Make sure not using resource integrity feature is safe here.
[warning] 57-57: Add an "aria-label" or "aria-labbelledby" attribute to this element.
[warning] 203-203: Add an "aria-label" or "aria-labbelledby" attribute to this element.
[warning] 11-11: Make sure not using resource integrity feature is safe here.
🔇 Additional comments (2)
data/mentors.json (1)
1587-1600: Good contact enrichment for both organizationsThese additions are solid and directly improve applicant discoverability (mailing list/email for NumFOCUS, and Discord/Discussions/mentor handles/email for omegaUp).
Also applies to: 1606-1658
index.html (1)
1030-1030: LGTM! Footer Privacy link correctly updated.The update from
href="#"tohref="privacy.html"properly links to the newly created privacy policy page, completing the navigation integration as described in the PR objectives.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 issues found across 3 files
Confidence score: 3/5
- There is a concrete user-facing risk in
data/mentors.json:mailto:links are currently filtered by the sanitizer, so newly added mentor email contacts would not render as intended. - The other findings in
privacy.htmlandindex.htmlare low-severity scope/focus issues rather than functional breakage, so they add process risk more than runtime risk. - Given the confirmed contact-link behavior issue (4/10 severity, high confidence), this carries some merge risk unless that sanitizer behavior is addressed.
- Pay close attention to
data/mentors.json,privacy.html, andindex.html- fixmailto:rendering for mentor contacts and separate unrelated privacy/footer changes into a dedicated PR.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="privacy.html">
<violation number="1" location="privacy.html:1">
P3: This new privacy policy page is unrelated to the PR’s stated mentor-contact update scope; please move it to a dedicated PR to keep this change set focused.
(Based on your team's feedback about keeping PRs scoped to the requested fix.) [FEEDBACK_USED]</violation>
</file>
<file name="data/mentors.json">
<violation number="1" location="data/mentors.json:1653">
P2: `mailto:` URLs in mentor contact data are filtered out by the current link sanitizer, so the added email contacts won’t be shown.</violation>
</file>
<file name="index.html">
<violation number="1" location="index.html:1030">
P3: This footer link edit is unrelated to the mentor-contact updates described in this PR. Please keep this PR scoped to the stated org-contact changes and move the Privacy-link update to a separate PR.
(Based on your team's feedback about keeping PRs tightly scoped to the intended fix.) [FEEDBACK_USED]</violation>
</file>
Tip: cubic used a learning from your PR history. Let your coding agent read cubic learnings directly with the cubic MCP.
Fix all with cubic
|
@S3DFX-CYBER can you review it manually? |
1 similar comment
|
@S3DFX-CYBER can you review it manually? |
|
@omkartike kindly resolve all conversations |
|
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="privacy.html">
<violation number="1" location="privacy.html:10">
P2: Using fixed SRI hashes on `fonts.googleapis.com/css2` stylesheets can cause the fonts CSS to be blocked for some user agents, because that endpoint returns user-agent-specific CSS.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
|
There was a problem hiding this comment.
♻️ Duplicate comments (2)
privacy.html (2)
203-203:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winLabel the footer navigation landmark for screen readers.
Line 203 should include an
aria-label(oraria-labelledby) so users can distinguish it from the main navigation region.Suggested patch
- <nav class="flex flex-wrap gap-6"> + <nav aria-label="Footer navigation" class="flex flex-wrap gap-6">🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@privacy.html` at line 203, The footer navigation <nav class="flex flex-wrap gap-6"> lacks an accessible landmark label; update that <nav> element by adding an appropriate aria-label (e.g., aria-label="Footer navigation" or aria-label="Footer links") or aria-labelledby referencing a visible footer heading so screen readers can distinguish it from the main navigation—modify the <nav class="flex flex-wrap gap-6"> node to include the chosen aria attribute and ensure the label text is meaningful and unique.
10-11:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd SRI + CORS attributes to external font stylesheets.
Line 10 and Line 11 still load third-party styles without integrity protection, so tampering detection is missing.
Suggested patch
- <link href="https://fonts.googleapis.com/css2?family=Plus+Jakarta+Sans:wght@400;500;600;700;800&family=Space+Grotesk:wght@400;500;600;700&family=Fira+Code:wght@400;500&display=swap" rel="stylesheet" /> - <link href="https://fonts.googleapis.com/css2?family=Material+Symbols+Outlined:wght,FILL@100..700,0..1&display=swap" rel="stylesheet" /> + <link href="https://fonts.googleapis.com/css2?family=Plus+Jakarta+Sans:wght@400;500;600;700;800&family=Space+Grotesk:wght@400;500;600;700&family=Fira+Code:wght@400;500&display=swap" rel="stylesheet" integrity="sha384-[REPLACE_WITH_HASH]" crossorigin="anonymous" /> + <link href="https://fonts.googleapis.com/css2?family=Material+Symbols+Outlined:wght,FILL@100..700,0..1&display=swap" rel="stylesheet" integrity="sha384-[REPLACE_WITH_HASH]" crossorigin="anonymous" />🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@privacy.html` around lines 10 - 11, The external Google Fonts link tags (href="https://fonts.googleapis.com/css2?family=Plus+Jakarta+Sans:..." and href="https://fonts.googleapis.com/css2?family=Material+Symbols+Outlined:...") lack Subresource Integrity and CORS attributes; compute the correct SRI SHA384 hashes for each stylesheet and add integrity="sha384-..." plus crossorigin="anonymous" to both <link> elements in privacy.html (or alternatively serve the fonts from a vetted local copy and update the hrefs accordingly). Ensure the integrity values match the exact fetched resources and update them if the remote files change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@privacy.html`:
- Line 203: The footer navigation <nav class="flex flex-wrap gap-6"> lacks an
accessible landmark label; update that <nav> element by adding an appropriate
aria-label (e.g., aria-label="Footer navigation" or aria-label="Footer links")
or aria-labelledby referencing a visible footer heading so screen readers can
distinguish it from the main navigation—modify the <nav class="flex flex-wrap
gap-6"> node to include the chosen aria attribute and ensure the label text is
meaningful and unique.
- Around line 10-11: The external Google Fonts link tags
(href="https://fonts.googleapis.com/css2?family=Plus+Jakarta+Sans:..." and
href="https://fonts.googleapis.com/css2?family=Material+Symbols+Outlined:...")
lack Subresource Integrity and CORS attributes; compute the correct SRI SHA384
hashes for each stylesheet and add integrity="sha384-..." plus
crossorigin="anonymous" to both <link> elements in privacy.html (or
alternatively serve the fonts from a vetted local copy and update the hrefs
accordingly). Ensure the integrity values match the exact fetched resources and
update them if the remote files change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 70010b77-291d-40b6-bf32-869b3382aa9a
📒 Files selected for processing (1)
privacy.html
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: cubic · AI code reviewer
🧰 Additional context used
🪛 GitHub Check: SonarCloud Code Analysis
privacy.html
[warning] 203-203: Add an "aria-label" or "aria-labbelledby" attribute to this element.
[warning] 10-10: Make sure not using resource integrity feature is safe here.
[warning] 11-11: Make sure not using resource integrity feature is safe here.
🔇 Additional comments (1)
privacy.html (1)
57-57: Good fix on main navigation accessibility label.Line 57 now has a clear landmark label; this resolves the earlier accessibility warning for the header nav.
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Auto-approved: This PR updates contact data for two GSoC organizations in a JSON file and adds a static privacy policy page, with no business logic or production infrastructure changes, making it low-risk and safe to auto-approve.
omkartike
dismissed stale reviews from cubic-dev-ai[bot] and coderabbitai[bot]
via
99e1352
|
|
@S3DFX-CYBER also fixed the issues in this pr got all security checks can you review this and let me know if anything else has to be updated ?? |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
index.html (1)
1111-1111: ⚡ Quick winPrefer direct in-page privacy navigation from the footer.
Since the policy now lives in
index.html#privacy, linking toprivacy.htmladds an avoidable reload + redirect hop for users already on the page.Proposed fix
- <a class="text-xs font-bold uppercase tracking-widest text-zinc-500 hover:text-orange-500 transition-all" href="privacy.html">Privacy</a> + <a class="text-xs font-bold uppercase tracking-widest text-zinc-500 hover:text-orange-500 transition-all" href="#privacy">Privacy</a>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@index.html` at line 1111, Update the footer anchor with text "Privacy" (the <a ...> element using class "text-xs font-bold uppercase tracking-widest text-zinc-500 hover:text-orange-500 transition-all") to point directly to the in-page fragment by changing its href from "privacy.html" to "#privacy" so clicks from index.html jump to the privacy section without a reload; keep the same attributes and text so behavior and styling are unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@index.html`:
- Line 1018: The new section with id="privacy" is missing from the existing
scroll-margin-top selector list, causing the anchored title to be hidden under
the fixed header; update the CSS rule that sets scroll-margin-top for anchored
sections (the selector list that currently targets your other section
IDs/classes) to include `#privacy`, or add a dedicated rule like "#privacy {
scroll-margin-top: var(--header-height); }" so the privacy section respects the
header offset when navigated to.
---
Nitpick comments:
In `@index.html`:
- Line 1111: Update the footer anchor with text "Privacy" (the <a ...> element
using class "text-xs font-bold uppercase tracking-widest text-zinc-500
hover:text-orange-500 transition-all") to point directly to the in-page fragment
by changing its href from "privacy.html" to "#privacy" so clicks from index.html
jump to the privacy section without a reload; keep the same attributes and text
so behavior and styling are unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 78d13253-eb3c-47ae-8c95-afaaecaa7719
📒 Files selected for processing (2)
index.htmlprivacy.html
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: cubic · AI code reviewer
🧰 Additional context used
🪛 GitHub Check: SonarCloud Code Analysis
privacy.html
[warning] 5-5: Remove this meta refresh tag.
🔇 Additional comments (1)
privacy.html (1)
1-13: Redirect page is clean and consistent.The redirect target, fallback anchor, and
noindexintent align well for the new in-page privacy flow.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@privacy.html`:
- Line 34: The object in privacy.html contains a duplicated color key
"on-secondary-container" with two different values; remove the duplicate so the
JS object has a single "on-secondary-container" entry (or rename the second key
if it was intended to be a different token) and ensure the remaining value is
the intended color to avoid silent overrides in theming.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b1bcb126-685c-4ad3-8caa-5a62f8611a42
📒 Files selected for processing (2)
index.htmlprivacy.html
✅ Files skipped from review due to trivial changes (1)
- index.html
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: cubic · AI code reviewer
🧰 Additional context used
🪛 GitHub Check: SonarCloud Code Analysis
privacy.html
[warning] 34-34: Duplicate name 'on-secondary-container'.
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="privacy.html">
<violation number="1" location="privacy.html:34">
P3: Duplicate color key `on-secondary-container` causes the first value to be overwritten, leaving dead config and likely an unintended theme token.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic
|
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Auto-approved: This PR adds verified mentor contact information to a static JSON data file, fixes a broken link in index.html, and introduces a new privacy.html page, all of which are low-risk data and documentation changes with no impact on core logic, security, or infrastructure.
|
|
already solved alll the conversations and solved alll the issues related to sonar cloud validation and also got the approval from both the code reviewer , i dont know why github action bot is showing this |
|
|
|
This workflow validates pull requests by checking for linked issues, required template sections, and conventional commit title format. It provides warnings for missing information and encourages contributors to combine related changes. Signed-off-by: Om Kartike <omkartikk2910@outlook.com>
- Added a new contact section with links to GitHub profile, issues, and Discord - Updated Contact button href from '#' to '#contact' for smooth scrolling - Added #contact to scroll-margin-top for proper header offset Signed-off-by: Om Kartike <omkartikk2910@outlook.com>
- Create privacy.html with comprehensive privacy policy content - Update footer Privacy link from href='#' to href='privacy.html' - Maintain consistent styling and navigation across pages Closes S3DFX-CYBER#444 Signed-off-by: Om Kartike <omkartikk2910@outlook.com>
Resolves S3DFX-CYBER#363 S3DFX-CYBER#364 This commit updates the mentor contact information for two organizations: NumFOCUS (S3DFX-CYBER#363): - Added mailing list: https://groups.google.com/a/numfocus.org/forum/#!forum/gsoc - Added email contact: gsoc@numfocus.org - Updated status to ok (verified and complete) - Added helpful tip for NumFOCUS umbrella organization omegaUp (S3DFX-CYBER#364): - Added Discord channels (GSoC candidates and community) - Added GitHub Discussions link - Added 5 named mentors: pabo99, heduenas, Ankitsinghsisodya, carlosabcs, iqbalcodes6602 - Added email contact: hello@omegaup.com - Updated status to ok (verified and complete) - Added helpful tips for arena test and Discord engagement Both organizations now have complete and verified contact information for GSoC 2026 applicants. Signed-off-by: Om Kartike <omkartikk2910@outlook.com>
Signed-off-by: Om Kartike <omkartikk2910@outlook.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> Signed-off-by: Om Kartike <omkartikk2910@outlook.com>
…acy section to index.html Signed-off-by: Om Kartike <omkartikk2910@outlook.com>
…g privacy.html a short policy page to reduce duplication Signed-off-by: Om Kartike <omkartikk2910@outlook.com>
….html and using standard colors Signed-off-by: Om Kartike <omkartikk2910@outlook.com>
omkartike
dismissed stale reviews from coderabbitai[bot] and cubic-dev-ai[bot]
via
431a990
omkartike
force-pushed
the
fix/mentor-contact-info
branch
from
714437d to
431a990
Compare
Signed-off-by: Om Kartike <omkartikk2910@outlook.com>
|
|
already verfied dco now |
2 participants
Program
NSoC'26
📝 Description
This PR updates the mentor contact information for two GSoC 2026 organizations by researching and verifying their communication channels, mentors, and contact details.
🔗 Related Issue
Closes #363 #364
🔄 Type of Change
📝 Data update
🧪 How to Test
✅ Checklist