fix: Error thrown during dry-run#952
Open
userwiths wants to merge 2 commits into
Open
Conversation
`get_local_name` refers to 2 "modes", when the destination is a folder and when its a file. It seems that `change_dir` should take into account if we are dry-running in both cases, but it was considering the option only when dest was a folder
steadytao
reviewed
Jun 3, 2026
steadytao
left a comment
steadytao
left a comment
There was a problem hiding this comment.
Thank you for fixing this. Confirmed fix.
This looks like the right behavioural fix to me. The only thing I would suggest is adding a small regression test for the single-file --dry-run --mkpath case so it stays covered.
Author
|
Not sure how things are handled here, so i used for example what i found in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #880
get_local_namerefers to 2 "modes", when the destination is a folder and when its a file.It seems that
change_dirshould take into account if we are dry-running in both cases, but it was considering the option only when dest was a folder