Skip to content

Parse advanced copy/paste format#9830

Open
Wires77 wants to merge 13 commits into
PathOfBuildingCommunity:devfrom
Wires77:advanced_copy_paste
Open

Parse advanced copy/paste format#9830
Wires77 wants to merge 13 commits into
PathOfBuildingCommunity:devfrom
Wires77:advanced_copy_paste

Conversation

@Wires77
Copy link
Copy Markdown
Member

@Wires77 Wires77 commented May 4, 2026

We've long not parsed the advanced format because of its complexity and just not being worth the effort. This PR attempts to resolve that.

Things to still do:

  • Copious tests outside of just some item examples
  • "Unscalable value" needs to be removed
  • Test with catalyzed values
  • Possibly trim reminder text
  • Make sure linePrefix is being reset even at the end of a section

@Wires77 Wires77 added enhancement New feature, calculation, or mod pob2 Label for features that should be ported over to PoB-PoE2 labels May 4, 2026
@Wires77 Wires77 marked this pull request as ready for review May 17, 2026 04:21
@Wires77 Wires77 marked this pull request as draft May 17, 2026 04:42
@Wires77
Copy link
Copy Markdown
Member Author

Wires77 commented May 17, 2026

Most of this is working, but I didn't fix copy/pasting influenced items yet, and in fact it causes an error right now after messing with adding/editing more custom mods:
image

@Wires77
Copy link
Copy Markdown
Member Author

Wires77 commented May 24, 2026

Three issues remain when testing this, but they may be out-of-scope for this PR:

  • Crafted hybrid mods in PoB scale their values in tandem, whereas in PoE each line can have values at the top/bottom of their range independently. E.g. A life/armour hybrid mod might have the maximum life value and minimum armour value. This can't happen when crafting an item in PoB, and thus pasted values might differ from what gets pasted in.
  • Pasting in mods modified to outside of their normal range via misting or volatile vaal orb end up showing strange slider placement. This causes weird behavior when changing other slider values, as ItemsTab first sorts the mods, then realizes one mod is outside of the possible range and removes it from the item (though not from the crafting sliders, and only if it's below the range. Above the range looks like the attached image)
image
  • The — 19% Increased suffix on a mod line is ignored unless the item has a catalyst applied. We already removed support for tailoring orbs, so this seems fine for now.

@Wires77 Wires77 marked this pull request as ready for review May 24, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod pob2 Label for features that should be ported over to PoB-PoE2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant