feat: remove snapshot image push#9
Merged
Merged
Conversation
Remove a workaround that pushed snapshot images. I added this, but AFAIK we're not actually using it, and it's currently making the linter mad. Signed-off-by: Travis Raines <571832+rainest@users.noreply.github.com>
Open
alexlovelltroy
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the snapshot image push workaround.
I added this, but AFAIK we're not actually using it. I checked through the first 7 results for https://github.com/search?q=org%3AOpenCHAMI+%22name%3A+Release+with+goreleaser%22&type=code and they're all triggering on tags and dispatch only.
We're maybe using dispatch to trigger this and using those images, but I think that's not the case. If I'm wrong, we should reject this!
The alternate way to fix the linter complaints in #8 is to remove the
if: truelines. IIRC I had those in place because I wanted to pass a dispatch checkbox for "release this snapshot image", and couldn't because of the bug mentioned in the comment. Best guess is that I wanted to only add the Docker-based build shared workflow in that PR, but forgot to remove stuff I was trying during the hackathon.