Remove bogus action test step#10
Open
rainest wants to merge 1 commit into
Open
Conversation
Remove a CI step that was labeled test-actions that wasn't actually testing actions, and was broken due to lack of the required secret. Signed-off-by: Travis Raines <571832+rainest@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this was failing, and then realized we're probably not actually using it, and it probably never worked.
This job is labeled
test-actions, but on review of steps, it's not doing that--it's building an RPM, which doesn't make sense for Actions.I'm not sure we can test the actions in this repo, as they only make sense if they're being called from other repos, as they generate release artifacts, and this repo doesn't have release artifacts of its own--it's just reuseable Action YAML.
This job was originally added in the initial commit, and likely never worked. https://github.com/OpenCHAMI/github-actions/actions/runs/16909466271 did not succeed, and while it no longer has full logs, the time corresponds with the last update of the (currently blank) GPG signing key secret.
My best guess is this was inadvertently copied from another repo when we made the shared repo to call these from.