fix(ui): add space separator between EndMissionEvent side and message#454
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Coverage Report for ui
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a space separator between the event side label and the message in the EventsTab component to improve UI spacing. A review comment suggests wrapping the side label and the space in a conditional rendering component to prevent a leading space glitch if the side data is missing, ensuring consistency with other parts of the codebase.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fank
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
EndMissionEventrow in the Events tab rendered the side label and the mission message in adjacent<span>elements with no whitespace between them, causing them to appear concatenated (e.g.WESTMission ended).Added a
{" "}text node between the two spans, matching the separator pattern already used forHitKilledEventname tokens.Before:

After:

Test plan
cd ui && npx vitest run— all 34 tests pass.Files
ui/src/pages/recording-playback/components/EventsTab.tsx— one-line fix inEndMissionEventrender branch.