Skip to content

refactor(packaging): rely on gateway runtime defaults#1415

Open
drew wants to merge 2 commits into
mainfrom
use-toml-in-install
Open

refactor(packaging): rely on gateway runtime defaults#1415
drew wants to merge 2 commits into
mainfrom
use-toml-in-install

Conversation

@drew
Copy link
Copy Markdown
Collaborator

@drew drew commented May 15, 2026

Summary

Remove package-time gateway TOML generation for Homebrew, Debian, RPM, and Snap. Package services now start openshell-gateway directly, keep OPENSHELL_* launch overrides working when present, and rely on runtime defaults plus an optional gateway TOML.

Related Issue

N/A

Changes

  • Added gateway runtime defaults for the optional XDG TOML path, SQLite state path, and local generated TLS bundle.
  • Updated Homebrew to read $XDG_CONFIG_HOME/openshell/gateway.toml when present and fall back to an existing Homebrew prefix config only when the XDG config is absent.
  • Updated Debian/RPM services to generate certs with openshell-gateway generate-certs and launch the gateway without --config or --db-url defaults.
  • Updated Snap to avoid writing TOML, set Snap-specific DB/TLS defaults through env, and read $SNAP_COMMON/gateway.toml only when it exists.
  • Removed the shared config generator and RPM PKI shell helper.
  • Kept env-variable compatibility without documenting the old env file name.
  • Updated package docs, man pages, gateway config/auth references, and release formula tests.

Testing

  • mise run pre-commit
  • uv run pytest python/openshell/release_formula_test.py
  • cargo test -p openshell-driver-docker
  • cargo test -p openshell-driver-podman grpc_endpoint
  • cargo test -p openshell-server cli::tests
  • cargo test -p openshell-server defaults::tests
  • cargo test -p openshell-core paths::tests
  • cargo test -p openshell-core config::tests
  • E2E tests added/updated (not applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

@drew drew requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners May 15, 2026 22:21
TaylorMutch
TaylorMutch previously approved these changes May 15, 2026
@github-actions
Copy link
Copy Markdown

@drew drew force-pushed the use-toml-in-install branch from f68e3a4 to 0db222c Compare May 15, 2026 22:50
@drew drew marked this pull request as draft May 15, 2026 23:12
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 15, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@drew drew force-pushed the use-toml-in-install branch 5 times, most recently from 3d47dc7 to a116ecd Compare May 17, 2026 16:49
@drew drew marked this pull request as ready for review May 17, 2026 16:51
@drew drew force-pushed the use-toml-in-install branch 3 times, most recently from f8fbb02 to 1a376b7 Compare May 17, 2026 18:14
@drew drew changed the title fix(packaging): use gateway TOML config in packages refactor(packaging): rely on gateway runtime defaults May 17, 2026
@drew drew marked this pull request as draft May 17, 2026 19:19
@TaylorMutch TaylorMutch marked this pull request as ready for review May 18, 2026 16:25
@TaylorMutch TaylorMutch added the test:e2e Requires end-to-end coverage label May 18, 2026
@TaylorMutch TaylorMutch self-assigned this May 18, 2026
@github-actions
Copy link
Copy Markdown

Label test:e2e applied for b07f372. Open the existing run and click Re-run all jobs to execute with the label set. The E2E Gate check on this PR will flip green automatically once the run finishes.

@TaylorMutch
Copy link
Copy Markdown
Collaborator

/ok to test b07f372

@TaylorMutch TaylorMutch force-pushed the use-toml-in-install branch from b07f372 to d053a31 Compare May 18, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants