fix: Update network nicknames and block explorer URLs#9005
fix: Update network nicknames and block explorer URLs#9005FrederikBolding wants to merge 3 commits into
Conversation
mikesposito
left a comment
There was a problem hiding this comment.
Current client overrides do not affect the initial state of NetworkController, so AFAIK these names are effectively used on onboarding users.
They are also the same as the client config API: https://client-config.api.cx.metamask.io/v1/config/networks
Not an issue, just something I thought it would be good to point out as it's unclear who should be the source of truth to align to
The changes here should also only apply to onboarding users, it is simply meant to standardize that across clients and ensure this is the default behaviour. |
Explanation
Updates all network nicknames to match overrides used by the clients. Additionally, ensure block explorer URLs are populated by default so the client doesn't have to do it.
References
https://consensyssoftware.atlassian.net/browse/WPC-1051
Checklist
Note
Low Risk
UI-facing display strings and default network metadata only; no auth, RPC, or transaction logic changes.
Overview
Aligns default built-in network display names with client overrides by updating
NetworkNicknamein@metamask/controller-utils(e.g.Ethereum Mainnet→Ethereum,BSC Mainnet→BNB Chain,Optimism Mainnet→OP).NetworkControllernow seeds default Infura network configurations with block explorer URLs fromBUILT_IN_NETWORKS(blockExplorerUrlsplusdefaultBlockExplorerUrlIndex: 0) instead of leaving them empty, so clients do not need to patch explorers separately.Changelogs and
NetworkControllertest snapshots/error strings were updated to match the new names and explorer fields.Reviewed by Cursor Bugbot for commit f166437. Bugbot is set up for automated code reviews on this repo. Configure here.