fix: Add proper defaults for RpcServiceOptions#9000
Merged
Conversation
FrederikBolding
commented
Jun 4, 2026
| const rpcServiceConfigurations = availableEndpointUrls.map((endpointUrl) => ({ | ||
| fetch: globalThis.fetch.bind(globalThis), | ||
| btoa: globalThis.btoa.bind(globalThis), | ||
| isOffline, |
Member
Author
There was a problem hiding this comment.
This was erroneously overriding any isOffline implementation passed in via getRpcServiceOptions. Instead, we now use it as a default.
Mrtenz
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Add proper defaults for
fetch,btoa, andisOfflineinRpcServiceOptions.References
https://consensyssoftware.atlassian.net/browse/WPC-1055
Checklist
Note
Cursor Bugbot is generating a summary for commit 57eb7e6. Configure here.