Skip to content

fix: Add proper defaults for RpcServiceOptions#9000

Merged
FrederikBolding merged 3 commits into
mainfrom
fb/network-controller-option-defaults
Jun 4, 2026
Merged

fix: Add proper defaults for RpcServiceOptions#9000
FrederikBolding merged 3 commits into
mainfrom
fb/network-controller-option-defaults

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

@FrederikBolding FrederikBolding commented Jun 4, 2026

Explanation

Add proper defaults for fetch, btoa, and isOffline in RpcServiceOptions.

References

https://consensyssoftware.atlassian.net/browse/WPC-1055

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Cursor Bugbot is generating a summary for commit 57eb7e6. Configure here.

const rpcServiceConfigurations = availableEndpointUrls.map((endpointUrl) => ({
fetch: globalThis.fetch.bind(globalThis),
btoa: globalThis.btoa.bind(globalThis),
isOffline,
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was erroneously overriding any isOffline implementation passed in via getRpcServiceOptions. Instead, we now use it as a default.

@FrederikBolding FrederikBolding marked this pull request as ready for review June 4, 2026 09:13
@FrederikBolding FrederikBolding requested review from a team as code owners June 4, 2026 09:13
@FrederikBolding FrederikBolding enabled auto-merge June 4, 2026 09:14
@FrederikBolding FrederikBolding added this pull request to the merge queue Jun 4, 2026
Merged via the queue into main with commit be6baf9 Jun 4, 2026
374 checks passed
@FrederikBolding FrederikBolding deleted the fb/network-controller-option-defaults branch June 4, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants