refactor: dedupe sentry trace#8994
Open
gambinish wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a4f810d. Configure here.
|
|
||
| traceData = { | ||
| success: false, | ||
| reason: didExceedOrderSubmissionThreshold ? 'late_error' : 'error', |
There was a problem hiding this comment.
Late error mislabels post-provider failures
Medium Severity
The catch path sets trace reason to late_error whenever didExceedOrderSubmissionThreshold is true, including when provider.placeOrder already finished successfully and a later step (e.g. #handleOrderSuccess or #trackOrderResult) throws. That labels a slow-but-successful submission as a late provider error in Sentry.
Reviewed by Cursor Bugbot for commit a4f810d. Configure here.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Explanation
Gaps to close (likely in the sibling client PRs, not core)
late_success/late_erroris the taxonomy used, rather thantimeoutso some dashboards may need to be updated.usePerpsMeasurement({ traceName: PerpsOrderSubmissionToast })fromusePerpsOrderExecution.ts, deleting the PerpsOrderSubmissionToast TraceName from app/util/trace.ts, and the mobile-side Promise.race.References
Checklist
Note
Medium Risk
Changes real order-submission observability and trace payloads for a core trading path; behavior intentionally avoids client-side cancellation, but consumers may rely on new
reasonvalues.Overview
Adds a 60s observational threshold (
PlaceOrderTimeoutMs) onTradingService.placeOrder: when the provider round-trip runs long, the code emits a warning breadcrumb and debug log but does not cancel the in-flightplaceOrder(avoids false failures if HyperLiquid still accepts the order).Perps Place Order trace end data now includes optional
reason:late_success/late_errorwhen the outcome arrives after the threshold, orerrorotherwise; successful fast paths omitreason.Removes the unused
Perps Order Submission Toastentry fromPerpsTraceName. Adds focused unit tests for threshold timing, trace reasons, and timer cleanup.Reviewed by Cursor Bugbot for commit a4f810d. Bugbot is set up for automated code reviews on this repo. Configure here.