feat(profile-metrics-controller): add proof of ownership API pre-requisites#8974
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a8b3301. Configure here.
ccharly
reviewed
Jun 3, 2026
gantunesr
reviewed
Jun 3, 2026
tommasini
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
References
Related to: https://consensyssoftware.atlassian.net/browse/MUL-1843
Checklist
Note
Medium Risk
Introduces authenticated nonce batching and optional cryptographic proofs sent to the auth API; behavior is well-tested but touches account-verification and bearer-token flows.
Overview
Adds proof-of-ownership plumbing in
@metamask/profile-metrics-controllerso later callers can verify accounts with the auth API.ProfileMetricsServicegainsfetchNonces(ProfileMetricsService:fetchNonces), callingPOST …/nonce/batchwith bearer auth,credentials: 'omit', optional entropy-source scoping, and 50-identifier chunking merged in parallel. Responses are validated with superstruct and rejected if identifiers are missing, extra, duplicated, or malformed (same retry/circuit policy assubmitMetrics).submitMetricsaccount payloads may include an optionalproof(nonce+signature); JSON includes it only when set.New
canonicalizeAddress(andProofUnsupportedNamespaceError) normalizes addresses per namespace (eip155,solana,tron,bip122) for auth API canonical forms—utility + tests only in this PR, not yet wired into the controller polling path.Reviewed by Cursor Bugbot for commit 5796ec4. Bugbot is set up for automated code reviews on this repo. Configure here.