feat(multichain-account-service): add deleteAccount to providers#8960
Open
hmalik88 wants to merge 27 commits into
Open
feat(multichain-account-service): add deleteAccount to providers#8960hmalik88 wants to merge 27 commits into
deleteAccount to providers#8960hmalik88 wants to merge 27 commits into
Conversation
montelaidev
reviewed
Jun 2, 2026
ccharly
reviewed
Jun 3, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5fc8a32. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
The
removeMultichainAccountWalletmethod was updated to properly delete all associated accounts with a wallet. ThedeleteAccountmethod was added to the providers to facilitate this.References
N/A
Checklist
Note
High Risk
Breaking messenger API plus multi-provider account deletion and keyring/snap removal paths are security- and data-sensitive; partial failures are swallowed while the wallet is still removed from service state.
Overview
Adds
deleteAccount(id)to theBip44AccountProvidercontract and wires it through EVM (v2 HDkeyring.deleteAccount), snap providers (SnapKeyring.removeAccount), andAccountProviderWrapper(always forwards, including when disabled).AccountProviderWrapperalso gainsunwrap()so wallet removal can list underlying snap accounts when basic functionality is off.BREAKING:
removeMultichainAccountWallet/MultichainAccountService:removeMultichainAccountWalletnow take onlyentropySource(theaccountAddressargument is removed). Removal walks every provider, deletes all accounts for that wallet viadeleteAccount, usesunwrap()for enumeration when wrappers are disabled, reports one aggregatedcaptureExceptionon partial failure, and still drops the wallet from the service map. Changelog and tests cover multi-provider cleanup, disabled-wrapper behavior, and error aggregation.Reviewed by Cursor Bugbot for commit c34218a. Bugbot is set up for automated code reviews on this repo. Configure here.