refactor: Move platform specific code from QtTrayMenu to tray_linux#137
Merged
ReenigneArcher merged 1 commit intoMay 26, 2026
Merged
Conversation
|
ReenigneArcher
approved these changes
May 26, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 63.69% 64.01% +0.32%
==========================================
Files 5 5
Lines 617 617
Branches 199 199
==========================================
+ Hits 393 395 +2
+ Misses 152 148 -4
- Partials 72 74 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Screenshot ComparisonPR #137 screenshots vs Matrix:
|
| Image | Baseline | PR |
|---|---|---|
tray_icon_initial.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_displayed.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
Matrix: Linux-qt6
| Image | Baseline | PR |
|---|---|---|
tray_icon_initial.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_displayed.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
Matrix: Windows
| Image | Baseline | PR |
|---|---|---|
tray_icon_initial.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_displayed.png |
 |
 |
Matrix: macOS
| Image | Baseline | PR |
|---|---|---|
tray_icon_initial.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_displayed.png |
 |
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently QtTrayMenu checks for WAYLAND_DISPLAY or x11 DISPLAY and sets QT_QPA_PLATFORM if neither is found. This is a linux platform specific workaround that needs moving to tray_linux for QtTrayMenu to be platform independent.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage