Merge 1.0.3 to main

[indrora]

Merge release-1.0 to main - Automated PR

[Copilot]

Pull request overview

This automated merge brings the release-1.0 changes (tagged as 1.0.3 in the changelog) into main, including documentation updates, new configuration options, and substantial refactoring around logging/error handling for the HydrantId AnyCA Gateway REST plugin.

Changes:

• Expanded documentation (README + docsource) to describe prerequisites, configuration, and supported behaviors.
• Added an Enabled CA-connection flag and broader guard clauses/logging refactors across plugin/client code (including the new FlowLogger utility).
• Updated revocation reason support to include reason code 0 (Unspecified) and adjusted project build outputs (multi-targeting).

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
README.md	Rebrands/updates links and significantly expands usage/config docs (currently includes duplicated “Installation” section and revocation reason mismatch).
integration-manifest.json	Updates release output location metadata and adds Enabled to CA connection config manifest.
HydrantCAProxy/RequestManager.cs	Refactors mapping/validation/logging; adds revoke reason 0 mapping but still omits reason 2.
HydrantCAProxy/HydrantIdCAPluginConfig.cs	Introduces Enabled config property and exposes it via annotations.
HydrantCAProxy/HydrantIdCAPlugin.csproj	Switches to multi-targeting and adds new package references.
HydrantCAProxy/HydrantIdCAPlugin.cs	Adds config masking, FlowLogger instrumentation, and many new guards; Ping() logic is currently incomplete.
HydrantCAProxy/FlowLogger.cs	New helper to emit structured “flow” trace logs.
HydrantCAProxy/Client/Models/Enums/RevocationReasons.cs	Adds Unspecified = 0 enum member.
HydrantCAProxy/Client/HydrantIdClient.cs	Adds extensive structured logging/guards and changes HTTP error handling behavior (still creates per-call HttpClient instances).
docsource/configuration.md	Major rewrite/expansion of configuration documentation (includes revocation reason mismatch).
CHANGELOG.md	Replaces prior content with HydrantId-focused version history entries.
.gitignore	Adds ignores for .claude settings and an unusual sample change.txt entry.

Comments suppressed due to low confidence (2)

HydrantCAProxy/HydrantIdCAPlugin.cs:929

• GetSingleRecord() now throws on most exceptions. This is a behavioral change from returning an AnyCAPluginCertificate with a FAILED status and may cause status checks/sync callers to fail hard. Consider returning a FAILED result object instead of throwing (or only throwing for truly unrecoverable errors), to match the method’s return-type contract.

            catch (AggregateException ae)
            {
                var inner = ae.Flatten().InnerException;
                flow.Fail("UNHANDLED", inner?.Message ?? ae.Message);
                _logger.LogError(inner ?? ae, "GetSingleRecord: AggregateException for caRequestID='{CaRequestId}': {Message}",
                    caRequestID ?? "(null)", inner?.Message ?? ae.Message);
                throw new Exception($"Error occurred getting single cert for '{caRequestID}': {inner?.Message ?? ae.Message}", inner ?? ae);
            }
            catch (Exception ex)
            {
                flow.Fail("UNHANDLED", ex.Message);
                _logger.LogError(ex, "GetSingleRecord: exception for caRequestID='{CaRequestId}': {Message}",
                    caRequestID ?? "(null)", ex.Message);
                throw new Exception($"Error occurred getting single cert for '{caRequestID}': {ex.Message}", ex);
            }

HydrantCAProxy/RequestManager.cs:239

• GetValidity() logs a warning and returns an empty CertRequestBodyValidity when period is unrecognized. That will produce an enrollment request with no validity set, which is likely to be rejected by the API or lead to unintended defaults. Consider throwing an ArgumentException for unsupported period values instead of silently continuing.

                CertRequestBodyValidity validity = new CertRequestBodyValidity();
                switch (period)
                {
                    case "Years":
                        validity.Years = units;
                        break;
                    case "Months":
                        validity.Months = units;
                        break;
                    case "Days":
                        validity.Days = units;
                        break;
                    default:
                        Log.LogWarning("GetValidity: unrecognized period '{Period}', no validity set", period);
                        break;
                }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.