Extend "get collection" use case to return theme#417
Conversation
ChengShi-1
left a comment
There was a problem hiding this comment.
Thanks for you contribution! This is really good. Could you also update the following?
- changelog.md
- integration test
- unit test
|
|
||
| export interface CollectionTheme { | ||
| id: number | ||
| logo: string |
There was a problem hiding this comment.
After reviewing the backend, it appears that they are all optional.
…n-theme # Conflicts: # CHANGELOG.md
Thank you for the review :) I've updated the changelog and added a unit test. For the integration test, I wasn't sure how to set up a comprehensive test for retrieving a theme, since I think that Dataverse doesn't have an API for setting a collection theme yet (? IQSS/dataverse#10194). But I have added a very simple integration test. |
|
Hi Vera, thanks for the changes. The integration test is failing because some of our storage driver api changed, which would be fixed by #431. I'll reply again when that one is merged, and then you could merge with the dev branch to make all checks pass. |
OK! 👍 |
What this PR does / why we need it:
This PR extends the "Get a collection" use case to also return its theme info, which is returned by the Dataverse API.
Which issue(s) this PR closes:
/
Related Dataverse PRs:
/
Special notes for your reviewer:
/
Suggestions on how to test this:
Use
getCollection.execute(collectionId)to read a collection. If it has a theme configured, e.g. a logo, that should be returned as part of the response.Is there a release notes or changelog update needed for this change?:
Yes
Additional documentation:
/