Skip to content

Extend "get collection" use case to return theme#417

Open
vera wants to merge 6 commits into
IQSS:developfrom
vera:feat/get-collection-theme
Open

Extend "get collection" use case to return theme#417
vera wants to merge 6 commits into
IQSS:developfrom
vera:feat/get-collection-theme

Conversation

@vera
Copy link
Copy Markdown
Contributor

@vera vera commented Jan 26, 2026

What this PR does / why we need it:

This PR extends the "Get a collection" use case to also return its theme info, which is returned by the Dataverse API.

Which issue(s) this PR closes:

/

Related Dataverse PRs:

/

Special notes for your reviewer:

/

Suggestions on how to test this:

Use getCollection.execute(collectionId) to read a collection. If it has a theme configured, e.g. a logo, that should be returned as part of the response.

Is there a release notes or changelog update needed for this change?:

Yes

Additional documentation:

/

@pdurbin pdurbin moved this to Ready for Triage in IQSS Dataverse Project Mar 31, 2026
@scolapasta scolapasta moved this from Ready for Triage to Ready for Review ⏩ in IQSS Dataverse Project Mar 31, 2026
@ChengShi-1 ChengShi-1 moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Apr 3, 2026
@ChengShi-1 ChengShi-1 self-assigned this Apr 3, 2026
@ChengShi-1 ChengShi-1 self-requested a review April 3, 2026 03:14
Copy link
Copy Markdown
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution! This is really good. Could you also update the following?

  1. changelog.md
  2. integration test
  3. unit test

@ChengShi-1 ChengShi-1 assigned vera and unassigned vera and ChengShi-1 Apr 3, 2026

export interface CollectionTheme {
id: number
logo: string
Copy link
Copy Markdown
Contributor

@ChengShi-1 ChengShi-1 Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing the backend, it appears that they are all optional.

@cmbz cmbz added the FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08) label Apr 8, 2026
@ekraffmiller ekraffmiller added the GREI Re-arch GREI re-architecture-related label Apr 8, 2026
@cmbz cmbz added the FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) label Apr 8, 2026
@cmbz cmbz added the FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) label Apr 22, 2026
@ChengShi-1 ChengShi-1 moved this from In Review 🔎 to On Hold ⌛ in IQSS Dataverse Project Apr 27, 2026
@vera
Copy link
Copy Markdown
Contributor Author

vera commented May 7, 2026

Thanks for you contribution! This is really good. Could you also update the following?

1. changelog.md

2. integration test

3. unit test

Thank you for the review :) I've updated the changelog and added a unit test.

For the integration test, I wasn't sure how to set up a comprehensive test for retrieving a theme, since I think that Dataverse doesn't have an API for setting a collection theme yet (? IQSS/dataverse#10194). But I have added a very simple integration test.

@ChengShi-1
Copy link
Copy Markdown
Contributor

ChengShi-1 commented May 19, 2026

Hi Vera, thanks for the changes. The integration test is failing because some of our storage driver api changed, which would be fixed by #431. I'll reply again when that one is merged, and then you could merge with the dev branch to make all checks pass.

@vera
Copy link
Copy Markdown
Contributor Author

vera commented May 20, 2026

Hi Vera, thanks for the changes. The integration test is failing because some of our storage driver api changed, which would be fixed by #431. I'll reply again when that one is merged, and then you could merge with the dev branch to make all checks pass.

OK! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08) FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) GREI Re-arch GREI re-architecture-related

Projects

Status: On Hold ⌛

Development

Successfully merging this pull request may close these issues.

6 participants