fw16: fix invalid GPU read lengths#339
Merged
JohnAZoidberg merged 3 commits intoMay 15, 2026
Merged
Conversation
This fixes an invalid read length that was truncating reads from the GPU descriptor EEPROM as the length is header+descriptor Signed-off-by: Kieran Levin <ktl@frame.work>
kiram9
changed the title
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix GPU descriptor EEPROM reads so the full header plus descriptor payload is read instead of only the descriptor payload length.
Changes:
- Updates GPU descriptor read length calculation to include
header.length. - Keeps descriptor magic validation before reading the full descriptor.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| )); | ||
| } | ||
| self.read_ec_gpu_chunk(0x00, header.descriptor_length as u16) | ||
| self.read_ec_gpu_chunk(0x00, (header.descriptor_length + header.length) as u16) |
| )); | ||
| } | ||
| self.read_ec_gpu_chunk(0x00, header.descriptor_length as u16) | ||
| self.read_ec_gpu_chunk(0x00, (header.descriptor_length + header.length) as u16) |
Signed-off-by: Kieran Levin <ktl@frame.work>
i2c verification was failing due to on windows there are additional bytes in the response from send_command. So truncate the extra bytes to the request size Signed-off-by: Kieran Levin <ktl@frame.work>
kiram9
changed the title
JohnAZoidberg
approved these changes
May 15, 2026
Member
|
Better than before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an invalid read length that was truncating reads from the GPU descriptor EEPROM as the length is header+descriptor.
This also fixes an issue on windows, where the i2c read will return extra bytes, so we just truncate the extra bytes to the expected response length.