chore: drop authEnabled config and document SPA mock-mode#217
Merged
Conversation
Pairs with smartem-frontend#101, which dropped the VITE_AUTH_ENABLED env var and the `authEnabled` field from runtime /config.json. Auth is now always on at the SPA level; the backend likewise enforces Bearer-token validation unconditionally (smartem-decisions#285). Changes: - k8s ConfigMaps in dev/staging/production drop the `authEnabled` field from the mounted config.json. The dev manifest's explanatory comment is updated to reflect that the toggle no longer exists. - docs/development/local-keycloak.md replaces the "Disabling auth entirely" section with a "Mock mode" section describing `npm run dev:smartem:mock` and the MockAuthProvider path. - keycloak-mock/README.md drops `authEnabled` from the config.json example. - docs/architecture/keycloak-spa-authentication.md adds a Mock-mode subsection under "Local development" and fixes a stale `SmartEM` client reference to `SmartEM_User`. The webui MDX mirrors are generated by webui/scripts/prebuild.ts from the docs/ sources and gitignored, so no MDX changes are committed; they regenerate on next `npm run prebuild`/`dev`/`build`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pairs with smartem-frontend#101, which dropped the
VITE_AUTH_ENABLEDenv var and theauthEnabledfield from runtime/config.json. Auth is now always on at the SPA level; the backend likewise enforces Bearer-token validation unconditionally (smartem-decisions#285).Changes
k8s/environments/{development,staging,production}/smartem-frontend.yaml): drop theauthEnabledfield from the mountedconfig.json. Dev manifest's explanatory comment updated to reflect the toggle no longer exists.docs/development/local-keycloak.md: replaces the "Disabling auth entirely" section with a "Mock mode" section describingnpm run dev:smartem:mockand theMockAuthProviderpath. Clarifies that mock mode is distinct from the "Keycloak unreachable" error state.keycloak-mock/README.md: dropsauthEnabledfrom theconfig.jsonexample.docs/architecture/keycloak-spa-authentication.md: adds a Mock-mode subsection under "Local development" describing theMockAuthProviderswap and MSW interception. Also fixes a staleSmartEMclient reference toSmartEM_User(the rename in smartem-frontend0b37453).Notes
webui/scripts/prebuild.tsfrom thedocs/sources and gitignored (webui/.gitignoreline 32), so no MDX changes are committed; they regenerate on nextnpm run prebuild/dev/build.config.jsonpath, just without the dead field.Test plan
python3 -c "yaml.safe_load_all(...)"clean).authEnabled/VITE_AUTH_ENABLEDreferences in the repo (only the new explanatory comment in the dev manifest references the historical name).cd webui && npm run prebuild) and confirm the architecture-doc and local-keycloak pages render the new Mock-mode copy in the webui dashboard.config.json(Keycloak URL still loaded, noauthEnabledreference path in the SPA code anyway as of smartem-frontend#101).