Skip to content

ci(workflow): drop hardcoded exec-maven-plugin:3.5.0 (PR-7.1)#80

Merged
DemchaAV merged 1 commit into
developfrom
ci/exec-plugin-drift-fix
May 30, 2026
Merged

ci(workflow): drop hardcoded exec-maven-plugin:3.5.0 (PR-7.1)#80
DemchaAV merged 1 commit into
developfrom
ci/exec-plugin-drift-fix

Conversation

@DemchaAV
Copy link
Copy Markdown
Owner

Summary

  • Replace three hardcoded org.codehaus.mojo:exec-maven-plugin:3.5.0:java invocations in .github/workflows/ci.yml with exec:java, so the CI workflow resolves the plugin through benchmarks/pom.xml's build/plugins declaration (3.6.3).
  • Add a Build entry to the in-progress v1.6.5 — Planned CHANGELOG section.

Why

benchmarks/pom.xml:134-138 already pins exec-maven-plugin:3.6.3 for
local benchmark runs, but CI bypassed that pin and invoked 3.5.0
directly — a silent version split between CI and local invocations
that grew the surface area to keep aligned. Using exec:java lets
Maven resolve the plugin through the module POM, so there is only one
version to bump going forward.

This is the third of three short branches unblocking the v1.6.5 cut
(alongside PR-7.2 #79 chore/byte-buddy-test-scope and PR-7.3
fix/pagebackgrounds-empty-and-row-weights). Tracked in the private
release-readiness taskboard.

Verification

The exact CI command was reproduced locally on JDK 17:

./mvnw -B -ntp -f benchmarks/pom.xml -DskipTests exec:java \
  -Dexec.mainClass=com.demcha.compose.CurrentSpeedBenchmark \
  -Dgraphcompose.benchmark.profile=smoke

Performance gate passed for profile smoke · BUILD SUCCESS · ~15 s.

The full and diff invocations follow the same pattern (only the
mainClass / profile / enforceGate flags differ), so plugin resolution
is identical.

Test plan

  • Smoke benchmark reproduced locally with the new exec:java invocation
  • CI perf-smoke green on PR
  • Required CI checks (Guards / JDK 17/21/25 / Examples Smoke) green on PR
  • Weekly benchmark-diff cron exercise — verified by maintainer post-merge (cron-only, not on PR)

…teps

The three CI benchmark steps (perf smoke, full benchmark, benchmark diff)
invoked org.codehaus.mojo:exec-maven-plugin:3.5.0:java directly, while
benchmarks/pom.xml already declared exec-maven-plugin at 3.6.3 for local
runs — a silent version split between CI and local invocations.

Switching CI to exec:java resolves the plugin through benchmarks/pom.xml's
build/plugins declaration (3.6.3), so there is only one version to bump.
Reproduced locally:

  ./mvnw -B -ntp -f benchmarks/pom.xml -DskipTests exec:java \
    -Dexec.mainClass=com.demcha.compose.CurrentSpeedBenchmark \
    -Dgraphcompose.benchmark.profile=smoke
  → Performance gate passed for profile smoke (BUILD SUCCESS, 15s)

Part of v1.6.5 publish hygiene (PR-7.1).
@DemchaAV DemchaAV force-pushed the ci/exec-plugin-drift-fix branch from 8b83b6b to d195a91 Compare May 30, 2026 09:44
@DemchaAV DemchaAV merged commit 966ccda into develop May 30, 2026
9 checks passed
@DemchaAV DemchaAV deleted the ci/exec-plugin-drift-fix branch May 30, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant