Skip to content

Upgrade ckeditor5 to v48#249

Open
jens-meisner wants to merge 15 commits into
mainfrom
upgrade-ckeditor5-to-v48
Open

Upgrade ckeditor5 to v48#249
jens-meisner wants to merge 15 commits into
mainfrom
upgrade-ckeditor5-to-v48

Conversation

@jens-meisner
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the workspace to CKEditor 5 v48 and aligns surrounding tooling (Node/PNPM, Playwright, Webpack config, and CI workflows) to keep the build and integration tests working with the newer CKEditor/toolchain.

Changes:

  • Bump ckeditor5 and related CKEditor dev tooling versions in the workspace catalog; add a large set of dependency overrides.
  • Update Node/PNPM engine requirements and CI workflow action versions / Node versions.
  • Adjust Webpack SVG handling and loosen some Playwright integration test assertions to accommodate the upgrade.

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
pnpm-workspace.yaml Updates catalog dependency versions for CKEditor/tooling and adds extensive dependency overrides.
package.json Bumps workspace engine requirements for Node and PNPM.
itest/src/PasteButton.test.ts Updates Playwright assertions/locators for paste-via-keyboard behavior and button handling.
itest/src/ContentLink.test.ts Adjusts keyboard flow and link assertion strategy for content-link suggestions test.
itest/package.json Removes per-package engines (presumably relying on root engines).
app/webpack.config.js Updates CKEditor dev-utils usage, removes license banner injection, replaces CKEditor icon loader with asset/source SVG handling.
app/package.json Removes per-package engines and drops raw-loader from devDependencies.
.github/workflows/unpublish.yml Updates actions/checkout major version.
.github/workflows/release.yml Bumps Node/PNPM versions used for release and updates checkout/setup-node actions.
.github/workflows/pre-release.yml Bumps Node/PNPM versions and updates checkout/setup-node actions.
.github/workflows/pre-release-gc.yml Updates checkout/setup-node actions.
.github/workflows/get-version.yml Updates setup-node action.
.github/workflows/codeql-analysis.yml Updates checkout action.
.github/workflows/build.yml Updates setup-node action.
Comments suppressed due to low confidence (1)

app/webpack.config.js:84

  • The CKEditor license banner injection was removed (previously via webpack.BannerPlugin with bundler.getLicenseBanner()). This means the generated bundle will no longer contain that license header. If you rely on it for license/compliance or to satisfy CKEditor build recommendations, add an alternative banner mechanism compatible with the new @ckeditor/ckeditor5-dev-utils version (or document why it’s no longer needed).
  plugins: [
    new CKEditorTranslationsPlugin({
      // UI language. Language codes follow the https://en.wikipedia.org/wiki/ISO_639-1 format.
      // When changing the built-in language, remember to also change it in the editor's configuration (src/ckeditor.js).
      language: "en",
      additionalLanguages: ["de"],
      sourceFilesPattern: "[/\\]ckeditor5/translations/[a-z]{2}.js",
    }),
    new CircularDependencyPlugin({
      exclude: /node_modules/,
      failOnError: true,
    }),
    new webpack.DefinePlugin({
      CKEDITOR_LICENSE_KEY: JSON.stringify(process.env.CKEDITOR_LICENSE_KEY),
    }),
  ],

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pnpm-workspace.yaml
Comment thread pnpm-workspace.yaml
Comment thread itest/src/PasteButton.test.ts
Comment thread itest/src/ContentLink.test.ts
Comment thread package.json
@jens-meisner jens-meisner force-pushed the upgrade-ckeditor5-to-v48 branch from 7a1aff3 to a906baf Compare May 29, 2026 13:42
@jens-meisner jens-meisner added the blocked Blocked by another issue or pull request label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Blocked by another issue or pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants