fix: respect http_proxy env vars in CLI API client#695
Merged
Conversation
Bun's native fetch does not automatically honour HTTPS_PROXY / http_proxy environment variables unlike Node's http/https modules. Read proxy settings from standard env vars and pass them via Bun's fetch option so corporate proxy users can route CLI traffic.
shabeer
requested review from
brandonkachen,
charleslien and
jahooma
as code owners
Contributor
Author
|
This possibly fixes the issue in #694 |
Contributor
Author
|
@jahooma @brandonkachen @charleslien - Any updates on the code review? |
Contributor
|
This might work for some api requests, but a lot are made through the sdk/agent-runtime packages. I'll merge this for now, but the whole proxy thing needs to be through through. We might just want to delete it if is tricky to make it actually work. |
Contributor
Author
|
Thanks @jahooma for merging the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bun's native fetch does not automatically honour HTTPS_PROXY / http_proxy environment variables unlike Node's http/https modules. Read proxy settings from standard env vars and pass them via Bun's fetch option so corporate proxy users can route CLI traffic.