Skip to content

Undo Windows Bun baseline target #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jahooma merged 1 commit into from
May 16, 2026
Merged

Undo Windows Bun baseline target #692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup-bun-compile-runtime/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: 'Download and cache a Bun runtime used by bun build --compile-execu

inputs:
target:
description: 'Bun compile target, for example bun-windows-x64-baseline'
description: 'Bun compile target, for example bun-windows-x64'
required: true

runs:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/cli-release-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,18 +315,18 @@ jobs:
echo "$ENV_OVERRIDES" | jq -r 'to_entries | .[] | .key + "=" + .value' >> $GITHUB_ENV
fi

- name: Prepare Windows baseline Bun compile runtime
- name: Prepare Windows Bun compile runtime
uses: ./.github/actions/setup-bun-compile-runtime
with:
target: bun-windows-x64-baseline
target: bun-windows-x64

- name: Build binary
run: bun run scripts/build-binary.ts ${{ inputs.binary-name }} ${{ inputs.new-version }}
working-directory: cli
shell: bash
env:
VERBOSE: true
OVERRIDE_TARGET: bun-windows-x64-baseline
OVERRIDE_TARGET: bun-windows-x64
OVERRIDE_PLATFORM: win32
OVERRIDE_ARCH: x64

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/freebuff-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,10 @@ jobs:
echo "NEXT_PUBLIC_CB_ENVIRONMENT=prod" >> $GITHUB_ENV
echo "CODEBUFF_GITHUB_ACTIONS=true" >> $GITHUB_ENV

- name: Prepare Windows baseline Bun compile runtime
- name: Prepare Windows Bun compile runtime
uses: ./.github/actions/setup-bun-compile-runtime
with:
target: bun-windows-x64-baseline
target: bun-windows-x64

- name: Build Freebuff binary
run: bun freebuff/cli/build.ts 0.0.0-e2e
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/npm-app-release-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
arch: arm64
- os: windows-latest
target: win32-x64
bun_target: bun-windows-x64-baseline
bun_target: bun-windows-x64
platform: win32
arch: x64
runs-on: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion cli/scripts/build-binary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ function getTargetInfo(): TargetInfo {
arch: 'arm64',
},
'win32-x64': {
bunTarget: 'bun-windows-x64-baseline',
bunTarget: 'bun-windows-x64',
platform: 'win32',
arch: 'x64',
},
Expand Down
Loading