Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | Wireframe#1380
Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | Wireframe#1380Tobias-Amaechina wants to merge 43 commits into
Conversation
…ing arial-describedby to aria-describedby in the fistname, last name and email, password input element
…me, email and password
…th and the alt description
…cle section of the wireframe
… git unique image also adding the h2 elemet
…icle elements tags, and the break point as well
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
Tobias-Amaechina
added
the
Needs Review
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
Bot
removed
the
Needs Review
Tobias-Amaechina
added
the
Needs Review
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
Bot
removed
the
Needs Review
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
Tobias-Amaechina
added
the
Needs Review
Tobias-Amaechina
changed the title
1 participant
Learners, PR Template
Self checklist
Changelist
Updated HTML structure to use semantic elements
Ensured proper heading hierarchy with
for page title and
for article titles![]()
with descriptive alt attributes for accessibility
Used
Implemented three distinct elements for content organisation
Added comprehensive alt text to all images for screen reader compatibility
Ensured proper color contrast ratios throughout the design
Verified semantic HTML structure supports assistive technologies
Used meaningful link text ("Read more") for context
Implemented proper heading hierarchy for document outline
Maintained linked style.css file with all styling rules
Organised CSS with clear sections: Design Palette, Base Elements, Site Layout, Grid Layout, and Article Layout
Used CSS custom properties (--color, --space, --container, etc.) for maintainable design system
Committed changes incrementally with descriptive commit messages
Pushed branch to GitHub for code review and collaboration
Followed proper branching strategy for feature development
Created three elements with unique content:
README Purpose - with image, title, summary, and "Read more" link
Wireframe Purpose - with image, title, summary, and "Read more" link
Git Branch Definition - with image, title, summary, and "Read more" link
Each article displays placeholder images with proper styling
Positioned footer with position: fixed; bottom: 0;
Ensured footer remains at bottom of viewport while scrolling content
Added proper bottom margin to main to prevent content overlap
Implemented responsive grid layout matching wireframe design
First article spans full width (grid-column: span 2)
Two-column grid for subsequent articles (grid-template-columns: 1fr 1fr)
Maintained consistent spacing using CSS variables