Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Wireframe/branch.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
91 changes: 64 additions & 27 deletions Wireframe/index.html
Original file line number Diff line number Diff line change
@@ -1,33 +1,70 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Wireframe</title>
<link rel="stylesheet" href="style.css" />
</head>
<body>
<header>
<h1>Wireframe</h1>

<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Wireframe</title>
<link rel="stylesheet" href="style.css" />
</head>

<body>
<header>
<h1>
<ul>
<li>
What is the purpose of a README file?
</li>
<li>
What is the purpose of a wireframe?
</li>
<li>
What is a branch in Git?
</li>
</ul>
Comment on lines +14 to +24
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wireframe has a "page title" instead of an unordered list. In addition, in the wireframe the page title and the text beneath it are centered.

This is the webpage to provide detail explanation for the above questions
</h1>
</header>
<main>
<article>
<img src="readme.svg" alt="" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing meaningful alt text is important because it ensures images are accessible to people using screen readers and also helps when images
fail to load, giving users essential context about the content or function of the image.

Can you give a more descriptive alt value to all images?

<h2>What is the purpose of a README file?</h2>
<p>
This is the default, provided code and no changes have been made yet.
A README file is the foundational documentation for a software, dataset, or coding project. It serves as a
project's "front door," designed to help users quickly understand what the project does, how to install and use
it, and how to contribute
</p>
</header>
<main>
<article>
<img src="placeholder.svg" alt="" />
<h2>Title</h2>
<p>
Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam,
voluptates. Quisquam, voluptates.
</p>
<a href="">Read more</a>
</article>
</main>
<footer>
<a
href="https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes">Read
more</a>
</article>

<article>
<img src="wireframe.svg" alt="" />
<h2>What is the purpose of a wireframe?</h2>
<p>
This is the default, provided code and no changes have been made yet.
Wireframes are the foundational blueprints of a website or app. Used early in the development process, they help
teams visualize structure, map user flows, and establish content hierarchy before committing to costly colors,
branding, or final UI design
</p>
</footer>
</body>
</html>
<a href="https://www.productplan.com/glossary/wireframe/">Read more</a>
</article>

<article>
<img src="branch.svg" alt="" />
<h2>What is a branch in Git?</h2>
<p>
A branch in Git is simply a lightweight movable pointer to one of these commits. The default branch name in Git
is master .
</p>
<a href="https://www.w3schools.com/GIT/git_branch.asp?remote=github">Read more</a>
</article>
</main>
<footer>
<p>
By ChunyanWong HOMEWORK FOR WIREFRAME SOLUTION
</p>
Comment on lines +64 to +66
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • To better match the wireframe, can you keep the footer content centered?

  • Currently the footer content and the article content could overlap. Can you find a way to prevent it from happening?

</footer>
</body>

</html>
18 changes: 18 additions & 0 deletions Wireframe/readme.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
18 changes: 14 additions & 4 deletions Wireframe/style.css
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two main selectors in this file. Consider merging the properties from both selectors into a single main rule to make them easier to find and maintain.

Original file line number Diff line number Diff line change
Expand Up @@ -24,23 +24,27 @@ As well as useful links to learn more */
--line: 1px solid;
--container: 1280px;
}

/* ====== Base Elements ======
General rules for basic HTML elements in any context */
body {
background: var(--paper);
color: var(--ink);
font: var(--font);
}

a {
padding: var(--space);
border: var(--line);
max-width: fit-content;
}

img,
svg {
width: 100%;
object-fit: cover;
}

/* ====== Site Layout ======
Setting the overall rules for page regions
https://www.w3.org/WAI/tutorials/page-structure/regions/
Expand All @@ -49,11 +53,13 @@ main {
max-width: var(--container);
margin: 0 auto calc(var(--space) * 4) auto;
}

footer {
position: fixed;
bottom: 0;
text-align: center;
}

/* ====== Articles Grid Layout ====
Setting the rules for how articles are placed in the main element.
Inspect this in Devtools and click the "grid" button in the Elements view
Expand All @@ -65,10 +71,12 @@ main {
display: grid;
grid-template-columns: 1fr 1fr;
gap: var(--space);
> *:first-child {

>*:first-child {
grid-column: span 2;
}
}

/* ====== Article Layout ======
Setting the rules for how elements are placed in the article.
Now laying out just the INSIDE of the repeated card/article design.
Expand All @@ -80,10 +88,12 @@ article {
text-align: left;
display: grid;
grid-template-columns: var(--space) 1fr var(--space);
> * {

>* {
grid-column: 2/3;
}
> img {

>img {
grid-column: span 3;
}
}
}
18 changes: 18 additions & 0 deletions Wireframe/wireframe.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading