London | May - 26 | Vito Moratti | Sprint 1 | Form-Controls

[vmoratti]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

After long struggle and then help from classmate. I am hopping to finally submit it.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	4410fab
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1acc1022439a0008cf0a2e
😎 Deploy Preview	https://deploy-preview-1372--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[cjyuan]

Note: There are special Markdown syntax for formatting checkboxes on GitHub.
Checkout this GitHub tasklist (list of check boxes) guide:
https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-tasklists

[cjyuan]

Code is error free and well formatted. Well done. I just have one request and some comments.

Note: If you haven't yet enabled "Format on save" on VS Code, consider following this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.

[cjyuan]

Note: If you embed <input> within <label>, use of id and for attributes are optional.

[vmoratti]

I have made adjustments to that

[cjyuan]

Note: Best practice is to move the CSS into an external .css file instead using inline CSS or embedding them within the HTML document. This improves maintainability, keeps the markup cleaner, and makes it easier to locate, update, and reuse styles across multiple pages.

No change is needed for this exercise.

[vmoratti]

style.css file is now added with styling.

[cjyuan]

• Can you also address this comment: London | May - 26 | Vito Moratti | Sprint 1 | Form-Controls #1372 (comment)

• No new commits were pushed to GitHub (It seems you made the commits on your Wireframe branch).

Your wireframe branch is outdated; it is 28 commits behind CYF's main. It's probably easier to create a new branch from your main and transfer your Wireframe implementation to the new branch than fixing the old branch.