Skip to content

London | 26-ITP-May | Martin Mwaka | Sprint 1 | Form Controls #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Temceo wants to merge 9 commits into
base: main
Choose a base branch
from
+131 −20
Open

London | 26-ITP-May | Martin Mwaka | Sprint 1 | Form Controls #1369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a18892f
add fields to form
Temceo May 9, 2026
ef44f77
update html and add style.css
Temceo May 10, 2026
62005c6
add colour styles
Temceo May 12, 2026
03dd0c2
update button background colour
Temceo May 12, 2026
eb46639
update min width of form
Temceo May 13, 2026
4a51a0f
update wireframe html
Temceo May 16, 2026
7a1a2e7
update html and css files
Temceo May 29, 2026
c15ae5d
add minimum length requiruement for username
Temceo May 30, 2026
da28db6
revert wireframe files to original
Temceo May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 61 additions & 20 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,68 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin="">
<link href="https://fonts.googleapis.com/css2?family=Poppins:ital,wght@0,100;0,200;0,300;0,400;0,500;0,600;0,700;0,800;0,900;1,100;1,200;1,300;1,400;1,500;1,600;1,700;1,800;1,900&amp;display=swap" rel="stylesheet">
<link rel="stylesheet" href="style.css">
<title>Form Controls</title>
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<div class="form-group">
<!-- input for name - required and validate -->
<label for="name">Name</label>
<input type="text"
id="name"
placeholder="Joe Bloggs"
required pattern="^(?=(?:.*\S){2,}).*$"
title="Please enter at least 2 non-space characters">
</div>
<div class="form-group">
<!-- input for email - required and validate -->
<label for="email">Email</label>
<input type="email" id="email" placeholder="joe@me.com" required="">
</div>
<div class="form-group">
<!-- Drop down list of 3 colours (green, blue, red) - required -->
<label for="colour">Choose colour</label>
<select name="colour" id="colour" required="">
<option value="" disabled="" selected="">Select a colour</option>
<option value="red">Red</option>
<option value="green">Green</option>
<option value="blue">Blue</option>
</select>
</div>

<div class="form-group">
<!-- Drop down list of 6 sizes (XS, S, M, L, XL, XXL) - required -->
<label for="size">Choose size</label>
<select name="size" id="size" required="">
<option value="" disabled="" selected="">Select a size</option>
<option value="xs">XS</option>
<option value="s">S</option>
<option value="m">M</option>
<option value="l">L</option>
<option value="xl">XL</option>
<option value="xxl">XXL</option>
</select>
</div>
<button type="submit" id="submit-btn">Submit</button>
</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
<p>By Martin Mwaka</p>
</footer>
</body>
</body>
</html>





Comment on lines +62 to +68
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look up why keeping trailing empty lines (blank lines at the end of a files) is generally considered poor practice in repositories?

Formatting tool such as prettier can often help us get rid of them automatically.

As a best practice, consider following this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.

70 changes: 70 additions & 0 deletions Form-Controls/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
* {
box-sizing: border-box;
margin: 0;
}

:root {
--clr-font-base: #DCE1DE;
--clr-bg-base: #216869;
--clr-bg-accent1: #3B8C88;
--clr-bg-accent2: #55AFAF;
--clr-bg-accent3: #70D2D2;
--clr-bg-dark1: #1A5354;
}

body {
font-family: "Poppins", sans-serif;
font-style: normal;
background-color: #570000;
color: #fff;
}

main, header, footer {
margin: auto;
width: 90%;
max-width: 750px;
}

form {
display: grid;
min-width: 350px;
gap: 1rem;
background-color: #280000;
padding: 2rem;
border-radius: 10px;
}

form {
@media (width > 720px) {
grid-template-columns: 1fr 1fr;
}
}

form button {
text-transform: uppercase;
background-color: #570000;
color: var(--clr-font-base);
font-weight: 500;
margin-top: 1rem;
height: 2.5rem;
border: none;
border-radius: 5px;
grid-column: 1 / -1;
justify-self: center;
width: 100%;
}

input, button, select {
font: inherit;
}

input, select {
width: 100%;
height: 2rem;
/* background-color: #570000; */
}

header h1, footer p {
text-align: center;
margin: 1.5rem;
}
Loading