Birmingham | ITP-May-26 | Toluwalase Tiamiyu | Sprint 1 | Form Control#1257
Birmingham | ITP-May-26 | Toluwalase Tiamiyu | Sprint 1 | Form Control#1257TTiamiyu wants to merge 9 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
@TTiamiyu |
|
I see erros in the w3 validator |
Luro91
left a comment
There was a problem hiding this comment.
A note on commit messages. It's hard to know for me what happens in a commit if the message is not descriptive. A commit should describe what changed in the code. It's also good practice to split commits into logical blocks (for example for each task or each review comment). This makes it easier to understand and additionally the commits could also be undone more easily if needed.
I like this article about commit messages: https://chris.beams.io/git-commit
i have rectified the errors regarding the white spaces in the "ID" and "Select name" attribute, i also used the validator.w3.org to check and it showed no errors
…code edited to align with the changes
…tions from reviewer
error seen by W3 validator regarding the "label for" not identical to the id, i have adjusted the case to align them.
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
removed the wireframe files from the form controls file, as it was committed here in error
…d added a button placement to make it look more like a form
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |

Learners, PR Template
Self checklist
Changelist
Enhances form accessibility and consistency by standardizing label capitalization and aligning input names and IDs. Updates option values for clarity and readability.