[SSF 220] - Auth Gating Controllers#185
Open
dburkhart07 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #220
📝 Description
For this PR, I added proper Role and Auth gating for all endpoints according to how they are used within the apiClient and frontend. I forgot to branch it off of #177 but any endpoint that was not auth-gated was because it is deleted in there, or did not need to be.
Additionally, I also standardized some of our backend controller formats, as we had a few endpoints that called the user's id and some attribute (e.g. /:pantryId/orders in pantry controller), and replaced it to be /me, since that format is much simpler and does not require an additional gating query.
Finally, I removed a few unused frontend files and the apiClient functions used in those files, since they were then deprecated.
✔️ Verification
Verified all routes worked and all tests still passed.
🏕️ (Optional) Future Work / Notes
N/A