SSF-205 FM Dashboard Frontend#173
Conversation
Yurika-Kan
left a comment
Yurika-Kan
left a comment
There was a problem hiding this comment.
small little fixes~ great pr!
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
first pass looks good, should hopefully be done after this! ty justinnnn
Yurika-Kan
left a comment
Yurika-Kan
left a comment
There was a problem hiding this comment.
this is awesome! thanks for adding the pagination deeplinking! found a missing portion regarding admin request management, but should be a quick fix~
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
i know you just implemented it but, based on yurika's point, can we actually not reset the pagination back to 1 on modal closing?
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
The deeplinking is still not working for me. Whenever I get off the page, it resets back to 1, rather than staying on the current page. I think we shouldn't need any deeplinking at all, and can just navigate back to the base url, and that should keep the UI state the exact same (including the page we are on).
Yurika-Kan
left a comment
Yurika-Kan
left a comment
There was a problem hiding this comment.
lgtm~
yayyyyyy dashboards are looking so so good & the linking functionality is def more user friendly now. thanks justin!
3 participants
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/browse/SSF-205
📝 Description
I simply implemented the food manufacturer dashboard frontend and linking functionality for both upcoming and recent donations.
/fm-dashboard
✔️ Verification
Verified proper functionality and aligned design with figma
🏕️ (Optional) Future Work / Notes
N/A