Skip to content

#95 - connect SES backend to existing email editor#126

Merged
thaninbew merged 5 commits into
mainfrom
piersol-email-comms-backend
May 30, 2026
Merged

#95 - connect SES backend to existing email editor#126
thaninbew merged 5 commits into
mainfrom
piersol-email-comms-backend

Conversation

@piersolh
Copy link
Copy Markdown
Contributor

@piersolh piersolh commented May 29, 2026

Description

Briefly describe the changes and why they are needed.

Changes Made

  • Backend changes
  • Frontend changes
  • Database schema changes
  • Configuration updates
  • Other

Testing & Verification

  • Unit tests pass
  • Manual testing completed
  • No breaking changes

Verification Steps:

  • Ran through each of the acceptance criteria, manually tested that an email was sent
  • Tested mass emails by sending to me personal email and a 10 minute mail account, only tested a few at a time to avoid throttling/excess costs

Screenshots (if relevant)

Donor message test

Screenshot 2026-05-28 at 10 11 50 PM

Mass email test

Screenshot 2026-05-28 at 9 35 18 PM (2) Screenshot 2026-05-28 at 10 11 50 PM

Lapsed Donor test - lapsed donor = last donation > 6 months ago

Screenshot 2026-05-28 at 9 40 06 PM

Future Improvements/Notes

  • refinement for templates, email currently goes straight to spam and the image doesn't load
  • unit tests?
  • I commented out auth for testing, auth needs to be enabled before shipping

Related Issues

Closes #95

@piersolh piersolh marked this pull request as ready for review May 29, 2026 02:14
@piersolh piersolh requested a review from thaninbew May 29, 2026 02:23
Copy link
Copy Markdown
Collaborator

@thaninbew thaninbew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!! everything works as expected. i verified the ses flow with my own keys, confirmed the automated dono response fires and sends me an email, i also checked that bulk sending works.

i'm requesting some changes mainly for security (authguard commented out), but while u are at it, there is just a couple more things and this feature will be solidified!

  • Re-enable the AuthGuard: we cant leave endpoints for bulk sending and template management public, or anyone could send spam or overwrite our settings.
  • as a standard, we need to have plain-text alternatives and a proper unsubscribe link in the footer.
  • make sure images are hosted on a cdn/s3 instead of being referenced locally. I will be doing that when i build the email signature.
  • add some basic logs for bulk failures and wrap the variable replacements in try/catch.

Additional notes:

  • i just built the save/load logic on the frontend so changes don't disappear on refresh.

@thaninbew thaninbew merged commit 0eae729 into main May 30, 2026
4 checks passed
@thaninbew thaninbew deleted the piersol-email-comms-backend branch May 30, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Email Communications (Backend, SES) Part 2 - don't start until Part 1 complete.

2 participants