Skip to content

fix(cli): preserve argument quoting for SingleCommand#346

Open
not-matthias wants to merge 1 commit into
mainfrom
fix/shell-words-join-single-command
Open

fix(cli): preserve argument quoting for SingleCommand#346
not-matthias wants to merge 1 commit into
mainfrom
fix/shell-words-join-single-command

Conversation

@not-matthias
Copy link
Copy Markdown
Member

Summary

  • Replace naive args.command.join(\" \") with shell_words::join when reconstructing the command string for SingleCommand, so arguments containing spaces or shell metacharacters are properly quoted before being passed to the orchestrator.

Test plan

  • cargo test
  • Run codspeed run -- some-cmd 'arg with spaces' and confirm the argument is preserved as a single token.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 12, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 7 untouched benchmarks


Comparing fix/shell-words-join-single-command (8aecf2d) with main (e3dba09)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant