jdbc-v2: update keywords and engines in JDBC#2861
Merged
Merged
Conversation
|
Repository collaborators can run the JMH benchmark suite against this PR by commenting: Optional regression threshold override (Δ% on Time or Alloc/op; defaults to 10%): Only one benchmark run per PR is active at a time — issuing a new |
|
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
mshustov
approved these changes
May 27, 2026
Contributor
Author
|
@BugBot review |
Member
|
@cursor[bot] |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 5eec56f. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes tests against HEAD version of ClickHouse
Checklist
Delete items not relevant to your PR:
Note
Low Risk
Static allowlists and metadata mappings only; no runtime behavior beyond parser keyword recognition and JDBC table type reporting.
Overview
Keeps jdbc-v2 in sync with newer ClickHouse server metadata by extending the SQL parser’s allowed keyword aliases and JDBC engine → table type map, plus a small Cursor skill for repeating the same maintenance when integration tests fail.
ClickHouseSqlUtilsgains six aliases (CURSOR,DETERMINISTIC,ESCAPE,SAMPLES,STREAM,UNKNOWN) soStatementSQLTest.testAllowedKeywordAliasesMatchSystemKeywordsmatchessystem.keywords.DatabaseMetaDataImplmaps the Paimon engine family (Paimon,PaimonAzure,PaimonHDFS,PaimonLocal,PaimonS3) toREMOTE TABLE, aligning with other lake/external engines forDatabaseMetaDataTest.testAllTableEnginesFromSystemTableEnginesAreMapped. A new.cursor/skills/update-keyword-engine-listsskill documents how to append entries from failing test output.Reviewed by Cursor Bugbot for commit 5eec56f. Bugbot is set up for automated code reviews on this repo. Configure here.