feat(sdk-core,abstract-utxo): add qr param and client-side output val…#8875
Open
davidkaplanbitgo wants to merge 2 commits into
Open
feat(sdk-core,abstract-utxo): add qr param and client-side output val…#8875davidkaplanbitgo wants to merge 2 commits into
davidkaplanbitgo wants to merge 2 commits into
Conversation
davidkaplanbitgo
requested a deployment
to
breaking-changes-override
GitHub Actions
Waiting
…idation Add the `qr` build parameter to the SDK and enforce client-side verification that quantum-resistant sweep transactions only contain wallet-internal outputs sdk-core: - Add `qr: t.boolean` to `BuildParamsUTXO` io-ts codec - Add `qr?: boolean` to `PrebuildTransactionOptions` interface abstract-utxo: - Add `qr?: boolean` to `TransactionParams` interface - Fixed-script verifyTransaction: when qr is true, reject any transaction with explicit or implicit external outputs - Descriptor verifyTransaction: same enforcement for descriptor wallets, throwing TxIntentMismatchError on external outputs - 7 new tests covering both verification paths Ticket: T1-3418 Co-authored-by: Cursor <cursoragent@cursor.com>
Bump public-types across all consuming packages to pick up the qr field on TxSendBody. Ticket: T1-3418
davidkaplanbitgo
requested a deployment
to
breaking-changes-override
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…idation
Add the
qrbuild parameter to the SDK and enforce client-side verification that quantum-resistant sweep transactions only contain wallet-internal outputs.sdk-core:
qr: t.booleantoBuildParamsUTXOio-ts codecqr?: booleantoPrebuildTransactionOptionsinterfaceabstract-utxo:
qr?: booleantoTransactionParamsinterfaceTicket: T1-3418