fix(mobile): match feed CollectionTile cover size + title weight to TrackTile#14432
Open
raymondjacobson wants to merge 1 commit into
Open
fix(mobile): match feed CollectionTile cover size + title weight to TrackTile#14432raymondjacobson wants to merge 1 commit into
raymondjacobson wants to merge 1 commit into
Conversation
…kTile Render the feed's CollectionTile header via LineupTileMetadata, the same component TrackTile uses, restoring the 72x72 cover art (down from full-width / aspect-ratio 1) and the bold title text (down from the title-variant strength=strong used by the card layout) so playlists no longer dominate the feed surface. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Ray reported:
Screenshot showed mobile Your Feed (For You / Latest) with a playlist ("Liquid Galaxy Album" by Zonii) where the cover art filled nearly the whole screen and the title font weight read lighter than the surrounding track-tile titles.
Root cause
#14428 (commit
17a4971337) replaced the feed CollectionTile's standard `LineupTileMetadata` header (the same one TrackTile uses) with an inline "card-style" header that rendered a full-width / `aspectRatio: 1` cover image above the metadata, and used `Text variant='title' strength='strong'` for the title.Fix
Restore `LineupTileMetadata` for the feed CollectionTile header so cover art renders at `{ width: 72, height: 72 }` (from `lineup-tile/styles.ts` `image`) and the title renders as `Text weight='bold'` — both matching TrackTile exactly. The rest of the tile (label, stats, track list, action buttons) is unchanged.
Behavior before -> after:
Shared-component note
`CollectionTile` is also used outside the mobile feed (chat-screen `ChatMessagePlaylist`, `CollectionLineupCarousel` on explore, `PlaylistsTab` / `AlbumsTab` on profile and library, `AddToCollectionDrawer`, `CollectionList`). They all rendered with the same `LineupTileMetadata` header for years prior to #14428 and will go back to that shape with this change. The pre-#14428 rendering is what those surfaces displayed historically; this PR restores the pre-existing baseline rather than introducing a new shape on them.
Suspected regression
#14428 /
17a4971337(fix(mobile): rich CollectionTile in lineups (large artwork + track list + duration)).Test plan
🤖 Generated with Claude Code