Antalya 26.3: Fixed alter table operations(add, modify, drop, rename) for iceberg #1794
Check failed
There are 66 commits incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🟢 | 3662a9b | Merge branch 'antalya-26.3' into feature/iceberg-t... | Skipped: sign-off not required in merge commit |
| 🔴 | ee0f215 | Merge pull request #1474 from Altinity/fix/antalya... | Sign-off not found |
| 🔴 | b9809c6 | Cherry-pick of https://github.com/Altinity/ClickHo... | Sign-off not found |
| 🔴 | 88c12d7 | Resolve conflicts in cherry-pick of #1631 | Sign-off not found |
| 🔴 | e277d0e | implement export partition all | Sign-off not found |
| 🔴 | ed9ef41 | Delete tests/queries/0_stateless/03609_export_merg... | Sign-off not found |
| 🔴 | 4a24375 | Delete tests/queries/0_stateless/03609_export_merg... | Sign-off not found |
| 🔴 | 2681daa | Update Settings.cpp | Sign-off not found |
| 🔴 | 7845271 | improve observability over exceptions | Sign-off not found |
| 🔴 | 3120261 | respect memory limit | Sign-off not found |
| 🔴 | 779b1d8 | remove lock inside the task export partition | Sign-off not found |
| 🔴 | be9859a | Iceberg type 'time' support | Sign-off not found |
| 🔴 | 4aea94f | Fix tests | Sign-off not found |
| 🔴 | c776a9d | Fix | Sign-off not found |
| 🔴 | 95768ac | Fix test | Sign-off not found |
| 🔴 | 6a7922d | Write time to Iceberg | Sign-off not found |
| 🔴 | bf357d2 | Proper write metadata to Avro | Sign-off not found |
| 🔴 | c5c9ea7 | Small fixes | Sign-off not found |
| 🔴 | 2ad3977 | Fixes, AI assist (Cursor + ChatGPT 5.5) | Sign-off not found |
| 🟢 | 6d579a4 | Merge branch 'antalya-26.3' into export_partition_... | Skipped: sign-off not required in merge commit |
| 🟢 | ac9e453 | Merge branch 'antalya-26.3' into feature/antalya-2... | Skipped: sign-off not required in merge commit |
| 🔴 | 10edb80 | Merge pull request ClickHouse#102628 from groeneai/fix-parqu... | Sign-off not found |
| 🔴 | 9291dc3 | Merge pull request ClickHouse#99935 from alesapin/fix_weird_... | Sign-off not found |
| 🔴 | 96d81f0 | Merge pull request ClickHouse#99521 from ivanmantova/feature... | Sign-off not found |
| 🔴 | 1441f6a | Merge pull request ClickHouse#100150 from ivanmantova/fix-ar... | Sign-off not found |
| 🔴 | edcf20c | Merge pull request ClickHouse#100645 from ClickHouse/divanik... | Sign-off not found |
| 🔴 | 79711c8 | fix gtest to use string instead of IcebergPath | Sign-off not found |
| 🔴 | 20f7fab | Added test cases for s3 encoding fix | Sign-off not found |
| 🔴 | c7fa981 | fix the vN-.metadata.json regression in getM... | Sign-off not found |
| 🔴 | 432f4dc | Fix stuck 'cluster_name_in_settings' | Sign-off not found |
| 🔴 | e03cd8e | Fix object_storage_remote_initiator+object_storage... | Sign-off not found |
| 🟢 | 8a1e9a3 | Merge branch 'antalya-26.3' into export_part_respe... | Skipped: sign-off not required in merge commit |
| 🟢 | 392163e | Merge branch 'antalya-26.3' into export_partition_... | Skipped: sign-off not required in merge commit |
| 🟢 | 9563398 | Merge branch 'antalya-26.3' into export_partition_... | Skipped: sign-off not required in merge commit |
| 🔴 | 8caab1b | Fix conditional check for Parquet file format | Sign-off not found |
| 🟢 | 40e329c | Merge branch 'antalya-26.3' into feature/antalya-2... | Skipped: sign-off not required in merge commit |
| 🟢 | f79c8c7 | Merge branch 'antalya-26.3' into 1338_fix_3_decodi... | Skipped: sign-off not required in merge commit |
| 🟢 | 4bdd9dc | Merge branch 'antalya-26.3' into feature/iceberg-t... | Skipped: sign-off not required in merge commit |
| 🔴 | 20dad73 | Hybrid: added support for segment pruning | Sign-off not found |
| 🔴 | 06905aa | hybrid: added system.hybrid_watermarks to inspect ... | Sign-off not found |
| 🔴 | 4a31253 | try to fix fasttest | Sign-off not found |
| 🟢 | f7fc0c5 | Merge branch 'antalya-26.3' into 1338_fix_3_decodi... | Skipped: sign-off not required in merge commit |
| 🟢 | deb4e77 | cross out all coverage suite fails | Valid sign-off found |
| 🟢 | 2d2caf5 | Regression tests: use release branch instead of co... | Valid sign-off found |
| 🟢 | 895fb8d | Fixed alter table operations(add, modify, drop, re... | Valid sign-off found |
| 🟢 | d29aec8 | Fixed alter table operations(add, modify, drop, re... | Valid sign-off found |
| 🔴 | e829313 | docs: explain how to get human-readable group name... | Sign-off not found |
| 🔴 | fdcb33b | doc: drop unnecessarily deep technical details | Sign-off not found |
| 🔴 | 14880ba | system.hybrid_watermarks: drop sorting, improve co... | Sign-off not found |
| 🔴 | d59077f | StorageDistributed: fix the comment (has_missing_o... | Sign-off not found |
| 🔴 | 0c0d328 | StorageDistributed: replace getAll() with getAllPh... | Sign-off not found |
| 🔴 | 1449fe7 | add RFC 7662 token introspection to the openid pro... | Sign-off not found |
| 🔴 | 105460d | Cherry-pick of https://github.com/ClickHouse/Click... | Sign-off not found |
| 🔴 | ac0e84b | Resolve conflicts in cherry-pick of ClickHouse#100334 | Sign-off not found |
| 🔴 | 8ebf38b | Cherry-pick of https://github.com/ClickHouse/Click... | Sign-off not found |
| 🔴 | 0045a22 | Resolve conflicts in cherry-pick of ClickHouse#102825 | Sign-off not found |
| 🔴 | 01237cf | Cherry-pick of https://github.com/ClickHouse/Click... | Sign-off not found |
| 🔴 | c783d78 | Resolve conflicts in cherry-pick of ClickHouse#102115 | Sign-off not found |
| 🔴 | b94cc0c | Cherry-pick of https://github.com/ClickHouse/Click... | Sign-off not found |
| 🔴 | 72c10ea | Resolve conflicts in cherry-pick of ClickHouse#104251 | Sign-off not found |
| 🔴 | 94fb179 | Cherry-pick of https://github.com/ClickHouse/Click... | Sign-off not found |
| 🔴 | dd79c20 | Resolve conflicts in cherry-pick of ClickHouse#96802 | Sign-off not found |
| 🟢 | 57b0578 | Merge branch 'antalya-26.3' into antalya_26_3_fix_... | Skipped: sign-off not required in merge commit |
| 🔴 | b69a888 | Fix CI: do not call getCatalog with _table_functio... | Sign-off not found |
| 🟢 | e9c25e1 | Merge pull request #1655 from Altinity/feature/ice... | Skipped: sign-off not required in merge commit |
| 🟢 | a0e4fdd | Merge pull request #1751 from Altinity/feature/ant... | Skipped: sign-off not required in merge commit |
| 🟢 | 3023406 | Merge pull request #1769 from Altinity/backports/a... | Skipped: sign-off not required in merge commit |
| 🟢 | 4c22ccc | Merge pull request #1781 from Altinity/1338_fix_3_... | Skipped: sign-off not required in merge commit |
| 🟢 | 7e36979 | Merge pull request #1788 from Altinity/mkmkme/anta... | Skipped: sign-off not required in merge commit |
| 🟢 | 5ff45f0 | Merge pull request #1789 from Altinity/mkmkme/anta... | Skipped: sign-off not required in merge commit |
| 🟢 | 245c8e9 | Merge pull request #1768 from Altinity/backports/a... | Skipped: sign-off not required in merge commit |
| 🟢 | 9b3b3bb | Merge pull request #1713 from Altinity/export_part... | Skipped: sign-off not required in merge commit |
| 🟢 | ba52e08 | Merge pull request #1742 from Altinity/feature/ant... | Skipped: sign-off not required in merge commit |
| 🟢 | a8f89a9 | Merge pull request #1776 from Altinity/backports/a... | Skipped: sign-off not required in merge commit |
| 🟢 | 6269508 | Merge pull request #1783 from Altinity/bugfix/anta... | Skipped: sign-off not required in merge commit |
| 🔴 | c93cae6 | Fix tsan lock-order-inversion between TokenAccessS... | Sign-off not found |
| 🟢 | 1398388 | Merge pull request #1804 from Altinity/feature/ant... | Skipped: sign-off not required in merge commit |
| 🟢 | c794675 | Merge pull request #1803 from Altinity/feature/ant... | Skipped: sign-off not required in merge commit |
| 🟢 | f8f931a | Merge pull request #1807 from Altinity/feature/ant... | Skipped: sign-off not required in merge commit |
| 🟢 | dafc225 | Merge pull request #1806 from Altinity/feature/ant... | Skipped: sign-off not required in merge commit |
| 🔴 | 5ff8096 | Cherry-pick of https://github.com/ClickHouse/Click... | Sign-off not found |
| 🔴 | 32ec2c8 | Resolve conflicts in cherry-pick of ClickHouse#101272 | Sign-off not found |
| 🔴 | ecf46b0 | Fix CI: support Nullable(Tuple) in `MsgPackRowIn... |
Sign-off not found |
| 🟢 | b239458 | Merge branch 'antalya-26.3' into feature/antalya-2... | Skipped: sign-off not required in merge commit |
| 🟢 | cea8a2d | Merge pull request #1800 from Altinity/feature/ant... | Skipped: sign-off not required in merge commit |
| 🟢 | 9466e61 | Merge remote-tracking branch 'origin/antalya-26.3'... | Skipped: sign-off not required in merge commit |
| 🔴 | 99ad855 | Fix CI: support Nullable(Tuple) in `CHColumnToAr... |
Sign-off not found |
| 🔴 | c1be814 | Fix CI: support Nullable(Tuple()) CSV roundtrip |
Sign-off not found |
| 🟢 | 7d8b25b | Merge branch 'antalya-26.3' into export_partition_... | Skipped: sign-off not required in merge commit |
| 🟢 | 0d80166 | Merge branch 'antalya-26.3' into export_partition_... | Skipped: sign-off not required in merge commit |
| 🔴 | 4c6d918 | fix SourceUpload job running when it shouldn't | Sign-off not found |
| 🔴 | 1769069 | same patch for finish jobs | Sign-off not found |
| 🔴 | e9155e7 | fix fast_test in community workflow | Sign-off not found |
| 🔴 | ae81ad2 | don't created Targeter in community PR | Sign-off not found |
| 🟢 | da39b8b | Merge pull request #1799 from Altinity/improvement... | Skipped: sign-off not required in merge commit |
| 🟢 | 836cc39 | Merge pull request #1802 from Altinity/feature/ant... | Skipped: sign-off not required in merge commit |
| 🟢 | 1e00b9c | Merge pull request #1741 from Altinity/export_part... | Skipped: sign-off not required in merge commit |
| 🟢 | 14640b5 | Merge pull request #1728 from Altinity/export_part... | Skipped: sign-off not required in merge commit |
| 🟢 | 48c56a0 | Merge pull request #1761 from Altinity/bugfix/anta... | Skipped: sign-off not required in merge commit |
| 🟢 | 4ac89c1 | Merge pull request #1774 from Altinity/backports/a... | Skipped: sign-off not required in merge commit |
| 🟢 | 5ac2165 | Merge branch 'antalya-26.3' into export_partition_... | Skipped: sign-off not required in merge commit |
| 🔴 | 29aae14 | update broken_tests.yaml | Sign-off not found |
| 🟢 | 54c8df3 | Merge pull request #1816 from strtgbb/fix_red_pr_w... | Skipped: sign-off not required in merge commit |
| 🟢 | 8524639 | Merge pull request #1730 from Altinity/export_part... | Skipped: sign-off not required in merge commit |
| 🔴 | 478570f | remove personal cursor rule | Sign-off not found |
| 🔴 | 9ffbacf | Update md files for new main branch | Sign-off not found |
| 🔴 | a799ae1 | import sign_and_release.yml from 26.1 | Sign-off not found |
| 🔴 | 6445986 | Address audit report fixes | Sign-off not found |
| 🟢 | 53f6ed5 | Merge branch 'antalya_26_3_fix_alter_table_iceberg... | Skipped: sign-off not required in merge commit |
| 🔴 | 503f9e4 | Merge conflicts | Sign-off not found |
| 🟢 | cb0fc35 | Merge pull request #1834 from Altinity/move-docs-2... | Skipped: sign-off not required in merge commit |
| 🟢 | 52fb56c | Merge branch 'antalya-26.3' into antalya_26_3_fix_... | Skipped: sign-off not required in merge commit |
| 🟢 | 2bf4158 | Merge branch 'antalya-26.3' into antalya_26_3_fix_... | Skipped: sign-off not required in merge commit |
| 🔴 | 373da96 | Fixed compilation error | Sign-off not found |
| 🟢 | 5cacdbd | Fixed compilation error | Skipped: sign-off not required for members |
| 🟢 | 7a101c1 | Merge branch 'antalya_26_3_fix_alter_table_iceberg... | Skipped: sign-off not required in merge commit |
| 🟢 | a2ca771 | Merge branch 'antalya_26_3_fix_alter_table_iceberg... | Skipped: sign-off not required in merge commit |
| 🟢 | 77bfd3d | DCO remediation commit for Kanthi Subramanian <sub... | Valid sign-off found |
| 🟢 | 8e8f4bc | DCO remediation commit for Kanthi Subramanian <sub... | Valid sign-off found |
| 🟢 | b8e6a18 | DCO remediation commit for Kanthi Subramanian <sub... | Valid sign-off found |
| 🟢 | 5163868 | DCO remediation commit for Kanthi Subramanian <sub... | Valid sign-off found |
| 🟢 | 04148e8 | DCO remediation commit for Kanthi Subramanian <sub... | Valid sign-off found |
| 🟢 | ffd21db | DCO remediation commit for Kanthi Subramanian <sub... | Skipped: sign-off not required for members |
| 🟢 | 08be5b6 | Merge branch 'antalya_26_3_fix_alter_table_iceberg... | Skipped: sign-off not required in merge commit |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~124 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin antalya_26_3_fix_alter_table_iceberg