Parcel appendTo appears to be broken

[alanquigley-toast]

When I set appendTo on a Parcel, I get a mount failure. The error leads back to the following line:

single-spa-react/src/parcel.js

Line 49 in c2cf485

this.parcel = mountParcel(this.props.config, {

When appendTo is set, the following React.createElement call never happens, so this.el is never set.

single-spa-react/src/parcel.js

Line 104 in 13e9fc8

return React.createElement(

When the call to getParcelProps function is made on line L51 the domElement is internally set to undefined, and the spread overrides the created domElement on L50

single-spa-react/src/parcel.js

Line 155 in 13e9fc8

const parcelProps = { ...this.props, domElement: this.el };

My question is, does this look like a bug, or is it related to my use-case currently. It seems like a bug.

Swapping lines L51 with L50 so that the newly generated domElement is added after the getParcelProps call does resolve the issue.

Happy to create a PR if required.

[SeverS]

Hi, I've encountered this issue as well, any plans on fixing it? I can also open a pr if needed.

[SeverS]

@alanquigley-toast @MilanKovacic sorry for pinging you but I need to decide if I proceed with a workaround or wait for a fix

[MilanKovacic]

Hi, PRs are always welcome. Feel free to submit one. If possible, also set up a minimal reproduction repository.

[SeverS]

Thanks @MilanKovacic, I've opened pr #199 and also added reproduction repository in the description.