Skip to content

build_sip_binding fails with Ninja build #111

@eaglesemanation

Description

@eaglesemanation

On Fedora 35 build of qt_gui_cpp fails with this error:

CMake Error:
  Running

   '/usr/bin/ninja-build' '-C' '/home/eaglesemanation/Documents/Packages/ros2_galactic/build/qt_gui_cpp' '-t' 'recompact'

  failed with:

   ninja: error: build.ninja:673: bad $-escape (literal $ must be written as $$)

That is caused by hard-coded Make variable $(MAKE) in sip_helper.cmake. If I change it to make everything works correctly, but I'm not sure if it's a good solution.
On my system, CMake defaults to Ninja generator because I have defined environment variable CMAKE_GENERATOR=Ninja. If it's not supported, it should probably be mentioned in docs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions