Skip to content

gh-149800: Split perf trampoline assembly into per-architecture files#149894

Merged
pablogsal merged 2 commits into
python:mainfrom
stratakis:split_trampolines
May 23, 2026
Merged

gh-149800: Split perf trampoline assembly into per-architecture files#149894
pablogsal merged 2 commits into
python:mainfrom
stratakis:split_trampolines

Conversation

@stratakis
Copy link
Copy Markdown
Contributor

@stratakis stratakis commented May 15, 2026

@stratakis
Copy link
Copy Markdown
Contributor Author

I believe this is a candidate for skip-news since it's refactoring.

I've tested the combinations on x86_64 and aarch64. Final binary has the proper hardware protections when used and gnu notes, perf tests pass, -Xperf and -Xperf_jit works fine through my testing and also for completeness I tested out of tree builds and they are fine as well.

For the build part I haven't tested the macOS, I don't have access to a machine, this needs to be verified. I followed there a similar convention as the jit_shim object.

Noting that the RISC-V support is broken, hence the lack of configure target, I just moved the assembly to its own file, I plan to provide a PR to fix it in the future, but hopefully after the implementation of automatic generation of dwarf info.

@vstinner
Copy link
Copy Markdown
Member

cc @pablogsal @savannahostrowski

@pablogsal
Copy link
Copy Markdown
Member

!buildbot perf

@bedevere-bot
Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 25df308 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F149894%2Fmerge

The command will test the builders whose names match following regular expression: perf

The builders matched are:

  • AMD64 NixOS Unstable Perf PR
  • AMD64 Arch Linux Perf PR

Copy link
Copy Markdown
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @stratakis

@pablogsal pablogsal merged commit b0a149a into python:main May 23, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants