Minor issue into configure.ac for the CYGWIN port

[carlo-bramini]

Bug report

Bug description:

I would like to signal these tiny issues into the configure.ac script for the Cygwin port.

In this line:

cpython/configure.ac

Line 337 in dfeeee9

ac_sys_system=Cygwin

the ac_sys_system is set to Cygwin, but perhaps it would be worth to change it to CYGWIN, just for coherency because CYGWIN is used in all other parts of the configure.ac script. It can be also done the opposite, replacing all CYGWIN to Cygwin just requires a find-and-replace in a text editor actually. It's just to use the one you like more.

In this line:

cpython/configure.ac

Line 1653 in dfeeee9

LDLIBRARY='libpython$(LDVERSION).dll.a'

the right value for the name of the static library must be:

LDLIBRARY='libpython$(LDVERSION).a'

In these lines:

cpython/configure.ac

Lines 3697 to 3698 in dfeeee9

	LDSHARED="gcc -shared -Wl,--enable-auto-image-base"
	LDCXXSHARED="g++ -shared -Wl,--enable-auto-image-base";;

it has been used gcc and g++, in my opinion they have to be changed to $(CC) an $(CXX).

See also #149879 for tracking issues of the port for Cygwin.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Windows

[zware]

Those all look like reasonable fixes, would you like to make a PR?

For the Cygwin vs CYGWIN question, we need to match whatever uname -s returns in the not cross_compiling case.