fix(scoop): handle non-UTF-8 encoding in scoop list output#1255
Merged
Conversation
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix tab completion failure for 'scoop list' on Windows when scoop output contains non-UTF-8 characters.
Problem
On Windows with non-UTF-8 locales (e.g., Chinese Windows using GBK encoding), the
scoop listcommand may output text in the system's local encoding, causing the completion to fail silently.Solution
Use
decode utf-8to properly handle the output encoding, ensuring the completion works correctly regardless of locale settings.Testing
Tested on Windows with Chinese locale where scoop outputs GBK-encoded text.