Refactor first run notice to show on any firtst execution, not just without args. (#232)

Fixes #229.

Author: azchohfi

src/winapp-CLI/WinApp.Cli/Program.cs

@@ -62,14 +62,18 @@ static async Task<int> Main(string[] args)
         using var serviceProvider = services.BuildServiceProvider();
 
         var firstRunService = serviceProvider.GetRequiredService<IFirstRunService>();
-        firstRunService.CheckAndDisplayFirstRunNotice();
+        var didShowFirstRunNotice = firstRunService.CheckAndDisplayFirstRunNotice();
 
         var rootCommand = serviceProvider.GetRequiredService<WinAppRootCommand>();
 
         // If no arguments provided, display banner and show help
         if (args.Length == 0)
         {
-            BannerHelper.DisplayBanner();
+            if (!didShowFirstRunNotice)
+            {
+                BannerHelper.DisplayBanner();
+            }
+
             // Show help by invoking with --help
             await rootCommand.Parse(["--help"]).InvokeAsync();
             return 0;

src/winapp-CLI/WinApp.Cli/Services/FirstRunService.cs

@@ -2,6 +2,7 @@
 // Licensed under the MIT License.
 
 using Microsoft.Extensions.Logging;
+using WinApp.Cli.Helpers;
 
 namespace WinApp.Cli.Services;
 
@@ -18,11 +19,13 @@ public FirstRunService(IWinappDirectoryService directoryService, ILogger<FirstRu
         _logger = logger;
     }
 
-    public void CheckAndDisplayFirstRunNotice()
+    public bool CheckAndDisplayFirstRunNotice()
     {
         _firstRunMarkerFile.Refresh();
         if (!_firstRunMarkerFile.Exists)
         {
+            BannerHelper.DisplayBanner();
+
             _logger.LogInformation("Welcome to the Windows App Development CLI! By using this tool, you agree to the collection of anonymous usage data to help improve the product. You can read the full privacy policy at https://go.microsoft.com/fwlink/?LinkId=521839");
             _logger.LogInformation("You can opt out of telemetry by setting the WINAPP_CLI_TELEMETRY_OPTOUT environment variable to '1'.");
             _logger.LogInformation("For more information, please visit: https://aka.ms/winappcli-telemetry-optout{NewLine}", Environment.NewLine);
@@ -37,6 +40,10 @@ public void CheckAndDisplayFirstRunNotice()
             {
                 _logger.LogWarning("Failed to create first run marker file: {ErrorMessage}", ex.Message);
             }
+
+            return true;
         }
+
+        return false;
     }
 }

src/winapp-CLI/WinApp.Cli/Services/IFirstRunService.cs

@@ -5,5 +5,5 @@ namespace WinApp.Cli.Services;
 
 internal interface IFirstRunService
 {
-    public void CheckAndDisplayFirstRunNotice();
+    public bool CheckAndDisplayFirstRunNotice();
 }